Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2699983002: ImageSkia: don't force fallback to a supported scale when the image (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, rsesek+watch_chromium.org, tdanderson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageSkia: don't force fallback to a supported scale when the image source advertises that it has representations for all scales. BUG=693227 Review-Url: https://codereview.chromium.org/2699983002 Cr-Commit-Position: refs/heads/master@{#451401} Committed: https://chromium.googlesource.com/chromium/src/+/41fb78271f7a247a47fd6a75a8f1953ff0282bce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/image/image_skia.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Evan Stade
+oshima for review +tdanderson for FYI
3 years, 10 months ago (2017-02-16 22:36:44 UTC) #2
oshima
lgtm
3 years, 10 months ago (2017-02-17 17:08:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699983002/1
3 years, 10 months ago (2017-02-17 19:53:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/284641)
3 years, 10 months ago (2017-02-17 20:34:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699983002/1
3 years, 10 months ago (2017-02-17 21:27:16 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 23:45:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41fb78271f7a247a47fd6a75a8f1...

Powered by Google App Engine
This is Rietveld 408576698