Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2699963002: Plumb bootclasspath GN -> Android Studio (Closed)

Created:
3 years, 10 months ago by agrieve
Modified:
3 years, 10 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb bootclasspath GN -> Android Studio This fixes most compile issues with android_webview. There is still an issue with a missing R.java though (updated comment in code about this). BUG=620034 Review-Url: https://codereview.chromium.org/2699963002 Cr-Commit-Position: refs/heads/master@{#451217} Committed: https://chromium.googlesource.com/chromium/src/+/a1c2f35132f2a07e14c64b633485195a705f848e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M build/android/gradle/android.jinja View 2 chunks +7 lines, -0 lines 0 comments Download
M build/android/gradle/generate_gradle.py View 2 chunks +7 lines, -1 line 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +3 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
agrieve
On 2017/02/16 19:53:51, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:wnwen@chromium.org
3 years, 10 months ago (2017-02-16 19:53:57 UTC) #3
Peter Wen
On 2017/02/16 19:53:57, agrieve wrote: > On 2017/02/16 19:53:51, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
3 years, 10 months ago (2017-02-16 20:12:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699963002/1
3 years, 10 months ago (2017-02-16 20:48:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/368246)
3 years, 10 months ago (2017-02-16 23:05:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699963002/1
3 years, 10 months ago (2017-02-17 02:31:00 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 04:45:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1c2f35132f2a07e14c64b633485...

Powered by Google App Engine
This is Rietveld 408576698