Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2699953002: Add acquire/release to global variable. (Closed)

Created:
3 years, 10 months ago by bcwhite
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Add acquire/release to global variable. In the case of subprocesses that create this after general initialization, it's possible for the thread that is doing the import is different than and created before the thread that creates the GlobalHistogramAllocator. Using release-store ensures that ctor initialization is complete before the global pointer is written while acquire-load ensures that all accesses to it come after the read of the global pointer. BUG=689245 Review-Url: https://codereview.chromium.org/2684993008 Cr-Commit-Position: refs/heads/master@{#449407} (cherry picked from commit 471e0a3d9789243b6db151544c8ca9da17b29f36) Review-Url: https://codereview.chromium.org/2699953002 . Cr-Commit-Position: refs/branch-heads/2987@{#554} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3ce527bfb13aed34dacc1f2605222b2b01bd0347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/metrics/persistent_histogram_allocator.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bcwhite
3 years, 10 months ago (2017-02-16 19:48:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ce527bfb13aed34dacc1f2605222b2b01bd0347.

Powered by Google App Engine
This is Rietveld 408576698