Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2699863002: [DevTools] prepare protocol config for new types in Runtime domain. (Closed)

Created:
3 years, 10 months ago by Yang
Modified:
3 years, 10 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] prepare protocol config for new types in Runtime domain. Protocol definition in v8 inspector is going to be extended by types ScriptCoverage and CoverageRange for the result of collecting code coverage. This change is in preparation for this change. R=kozyatinskiy@chromium.org, pfeldman@chromium.org BUG=v8:5808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/devtools/protocol_config.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
Yang
3 years, 10 months ago (2017-02-16 12:38:34 UTC) #1
Yang
On 2017/02/16 12:38:34, Yang wrote: The CL on V8 side is https://codereview.chromium.org/2700743002/
3 years, 10 months ago (2017-02-16 12:39:58 UTC) #2
kozy
3 years, 10 months ago (2017-02-16 18:15:53 UTC) #7
It was issue of browser_config.json. will be fixed soon with
https://codereview.chromium.org/2705443002/

Powered by Google App Engine
This is Rietveld 408576698