kiosk: UMA for launch error

kiosk: UMA for launch error

- Add "Kiosk.Launch.Error" for kiosk launch error;
- Add "Kiosk.Launch.CryptohomeFailure" for cryptohome failure
  during kiosk launch;

BUG=692584
Review-Url: https://codereview.chromium.org/2699833005
Cr-Commit-Position: refs/heads/master@{#453977}
Committed: https://chromium.googlesource.com/chromium/src/+/2767f077859e7fc185170dddab62124691369085

[xiyuan, 2017-02-16 17:51:19]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 17:52:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 18:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 18:01:21]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[xiyuan, 2017-02-27 23:19:28]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 23:20:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 00:34:37]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-02-28 18:38:34]

xiyuan@chromium.org changed reviewers:
+ isherman@chromium.org, tbarzic@chromium.org

[tbarzic, 2017-02-28 19:18:55]

lgtm

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc (right):

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc:32: return
std::string();
I'd treat ERROR_COUNT as an unknown error - NOTREACHED() and return
FAILED_TO_LAUNCH message

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h (right):

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h:35: ERROR_COUNT,      
           // Count of all errors. Must be the last one.
I'd remove "Must be at least one" - there already is a comment not to remove
entries, so the fact ERROR_COUNT has to be >=1 is a moot point :)

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h:41: // Saves error for
displaying and metric reporting on next chrome run.
nit: how about:
"Saves a launch error - used on the next Chrome run to report metrics and
display a message to the user."

[xiyuan, 2017-02-28 21:14:57]

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc (right):

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc:32: return
std::string();
On 2017/02/28 19:18:55, tbarzic wrote:
> I'd treat ERROR_COUNT as an unknown error - NOTREACHED() and return
> FAILED_TO_LAUNCH message

Done.

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h (right):

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h:35: ERROR_COUNT,      
           // Count of all errors. Must be the last one.
On 2017/02/28 19:18:55, tbarzic wrote:
> I'd remove "Must be at least one" - there already is a comment not to remove
> entries, so the fact ERROR_COUNT has to be >=1 is a moot point :)

Done.

https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app...
chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h:41: // Saves error for
displaying and metric reporting on next chrome run.
On 2017/02/28 19:18:55, tbarzic wrote:
> nit: how about:
> "Saves a launch error - used on the next Chrome run to report metrics and
> display a message to the user."

Done.

[xiyuan, 2017-02-28 21:15:06]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 21:15:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 22:36:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:36:29]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-03-01 00:44:26]

Metrics LGTM

https://codereview.chromium.org/2699833005/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h (right):

https://codereview.chromium.org/2699833005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h:52: // Records the
launch error metric and clears it.
Perhaps document that this method records and clears the auth error metric as
well?

[xiyuan, 2017-03-01 17:01:35]

https://codereview.chromium.org/2699833005/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h (right):

https://codereview.chromium.org/2699833005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h:52: // Records the
launch error metric and clears it.
On 2017/03/01 00:44:26, Ilya Sherman wrote:
> Perhaps document that this method records and clears the auth error metric as
> well?

Done.

[xiyuan, 2017-03-01 17:01:42]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2017-03-01 17:01:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
tbarzic@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2699833005/#ps40001
(title: "update comment")

[commit-bot: I haz the power, 2017-03-01 17:02:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 18:27:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488387702081090,
"parent_rev": "64816da615023d3bb69a30562d7a27fa10da31c2", "commit_rev":
"2767f077859e7fc185170dddab62124691369085"}

[commit-bot: I haz the power, 2017-03-01 18:28:38]

Description was changed from

==========
kiosk: UMA for launch error

- Add "Kiosk.Launch.Error" for kiosk launch error;
- Add "Kiosk.Launch.CryptohomeFailure" for cryptohome failure
  during kiosk launch;

BUG=692584
==========

to

==========
kiosk: UMA for launch error

- Add "Kiosk.Launch.Error" for kiosk launch error;
- Add "Kiosk.Launch.CryptohomeFailure" for cryptohome failure
  during kiosk launch;

BUG=692584

Review-Url: https://codereview.chromium.org/2699833005
Cr-Commit-Position: refs/heads/master@{#453977}
Committed:
https://chromium.googlesource.com/chromium/src/+/2767f077859e7fc185170dddab62...
==========

[commit-bot: I haz the power, 2017-03-01 18:28:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2767f077859e7fc185170dddab62...