Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2699833005: kiosk: UMA for launch error (Closed)

Created:
3 years, 10 months ago by xiyuan
Modified:
3 years, 9 months ago
Reviewers:
Ilya Sherman, tbarzic
CC:
chromium-reviews, asvitkine+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: UMA for launch error - Add "Kiosk.Launch.Error" for kiosk launch error; - Add "Kiosk.Launch.CryptohomeFailure" for cryptohome failure during kiosk launch; BUG=692584 Review-Url: https://codereview.chromium.org/2699833005 Cr-Commit-Position: refs/heads/master@{#453977} Committed: https://chromium.googlesource.com/chromium/src/+/2767f077859e7fc185170dddab62124691369085

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase, for #1 comments #

Total comments: 2

Patch Set 3 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -48 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h View 1 2 1 chunk +27 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc View 1 5 chunks +33 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/auth_status_consumer.h View 1 chunk +16 lines, -14 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +39 lines, -12 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
xiyuan
3 years, 9 months ago (2017-02-28 18:38:34 UTC) #10
tbarzic
lgtm https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc (right): https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc#newcode32 chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc:32: return std::string(); I'd treat ERROR_COUNT as an unknown ...
3 years, 9 months ago (2017-02-28 19:18:55 UTC) #11
xiyuan
https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc (right): https://codereview.chromium.org/2699833005/diff/1/chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc#newcode32 chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc:32: return std::string(); On 2017/02/28 19:18:55, tbarzic wrote: > I'd ...
3 years, 9 months ago (2017-02-28 21:14:57 UTC) #12
Ilya Sherman
Metrics LGTM https://codereview.chromium.org/2699833005/diff/20001/chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h (right): https://codereview.chromium.org/2699833005/diff/20001/chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h#newcode52 chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h:52: // Records the launch error metric and ...
3 years, 9 months ago (2017-03-01 00:44:26 UTC) #17
xiyuan
https://codereview.chromium.org/2699833005/diff/20001/chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h File chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h (right): https://codereview.chromium.org/2699833005/diff/20001/chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h#newcode52 chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h:52: // Records the launch error metric and clears it. ...
3 years, 9 months ago (2017-03-01 17:01:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699833005/40001
3 years, 9 months ago (2017-03-01 17:02:17 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 18:28:39 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2767f077859e7fc185170dddab62...

Powered by Google App Engine
This is Rietveld 408576698