Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2699793003: MD Settings: Add MIDI devices to Content Settings (Closed)

Created:
3 years, 10 months ago by tommycli
Modified:
3 years, 10 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add MIDI devices to Content Settings BUG=691711 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2699793003 Cr-Commit-Position: refs/heads/master@{#451114} Committed: https://chromium.googlesource.com/chromium/src/+/3d718c1107d57b641ae0a77e6c491c76c3c05fb3

Patch Set 1 #

Patch Set 2 : add icon and fix tests #

Messages

Total messages: 19 (13 generated)
tommycli
dschuyler: PTAL. There's some UI clarifications needed (see the bug) but the code itself is ...
3 years, 10 months ago (2017-02-15 23:40:16 UTC) #5
tommycli
dschuyler: Hello, I have fixed the tests and updated the icon. UI has been looked ...
3 years, 10 months ago (2017-02-16 19:43:25 UTC) #10
dschuyler
lgtm
3 years, 10 months ago (2017-02-16 20:11:33 UTC) #11
tommycli
On 2017/02/16 20:11:33, dschuyler wrote: > lgtm alrighty thank you, submitting
3 years, 10 months ago (2017-02-16 20:12:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699793003/20001
3 years, 10 months ago (2017-02-16 20:31:32 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 22:19:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d718c1107d57b641ae0a77e6c49...

Powered by Google App Engine
This is Rietveld 408576698