Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2699793002: [parser cleanup] Simplify statement parsing logic (Closed)

Created:
3 years, 10 months ago by adamk
Modified:
3 years, 10 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com, caitp
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser cleanup] Simplify statement parsing logic This changes most callers of ParseScopedStatement to call a new, simpler form of ParseStatement, which takes only |labels| and |ok|. This allows us to remove the |legacy| attribute from ParseScopedStatement. The only remaining caller of ParseScopedStatement is ParseIfStatement. This patch is a strict refactoring, and should change no behavior. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2699793002 Cr-Commit-Position: refs/heads/master@{#43259} Committed: https://chromium.googlesource.com/v8/v8/+/ad2a30a962a3e6cbf1ca048e66993e17af2dda2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -30 lines) Patch
M src/parsing/parser-base.h View 12 chunks +20 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
adamk
3 years, 10 months ago (2017-02-15 23:02:17 UTC) #1
Dan Ehrenberg
lgtm Thanks for this cleanup following removal of the flag.
3 years, 10 months ago (2017-02-16 09:25:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699793002/1
3 years, 10 months ago (2017-02-16 18:42:15 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 18:50:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ad2a30a962a3e6cbf1ca048e66993e17af2...

Powered by Google App Engine
This is Rietveld 408576698