Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2699773003: Add Widevine signature files for Win into the build (Closed)

Created:
3 years, 10 months ago by jrummell
Modified:
3 years, 10 months ago
Reviewers:
gab, xhwang
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, eme-reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Widevine signature files for Win into the build Add the signature files so that they get packaged with the installer. BUG=693184 Review-Url: https://codereview.chromium.org/2699773003 Cr-Commit-Position: refs/heads/master@{#451433} Committed: https://chromium.googlesource.com/chromium/src/+/e21cbdc60d0f618166b2d53ebb306e8e79d664f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/installer/mini_installer/chrome.release View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
jrummell
PTAL.
3 years, 10 months ago (2017-02-16 18:56:29 UTC) #6
xhwang
Did you try an official build and check the result? Otherwise LGTM! Thank you for ...
3 years, 10 months ago (2017-02-16 20:21:34 UTC) #7
jrummell
+gab@ for OWNERS review of chrome/ files (adding a file to Windows installer)
3 years, 10 months ago (2017-02-16 22:16:22 UTC) #10
gab
installer lgtm
3 years, 10 months ago (2017-02-17 20:54:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699773003/1
3 years, 10 months ago (2017-02-17 22:20:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-18 00:24:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699773003/1
3 years, 10 months ago (2017-02-18 04:04:15 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 06:55:04 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e21cbdc60d0f618166b2d53ebb30...

Powered by Google App Engine
This is Rietveld 408576698