Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2699723002: Update Ash strings to use sentence case (Closed)

Created:
3 years, 10 months ago by tdanderson
Modified:
3 years, 10 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Ash strings to use sentence case Updates all Ash strings currently using Title Case to instead use Sentence case. BUG=690522 TEST=none Review-Url: https://codereview.chromium.org/2699723002 Cr-Commit-Position: refs/heads/master@{#450831} Committed: https://chromium.googlesource.com/chromium/src/+/2f271eacfbb2eb9e9744b07d3e55d6bc5b9531eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M ash/ash_chromeos_strings.grdp View 7 chunks +11 lines, -11 lines 0 comments Download
M ash/ash_strings.grd View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tdanderson
James, can you please take a look?
3 years, 10 months ago (2017-02-15 20:51:00 UTC) #4
James Cook
LGTM
3 years, 10 months ago (2017-02-15 21:52:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699723002/1
3 years, 10 months ago (2017-02-15 21:59:32 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 23:15:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f271eacfbb2eb9e9744b07d3e55...

Powered by Google App Engine
This is Rietveld 408576698