Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 2699713007: MD-Settings: Add a11y label for network summary items. (Closed)

Created:
3 years, 10 months ago by hcarmona
Modified:
3 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD-Settings: Add a11y label for network summary items. R=stevenjb@chromium.org BUG=693370 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2699713007 Cr-Commit-Position: refs/heads/master@{#451838} Committed: https://chromium.googlesource.com/chromium/src/+/946a9f3c1606d0e90b11303580e9b56d5ecf7432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.js View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
hcarmona
PTAL
3 years, 10 months ago (2017-02-17 21:51:11 UTC) #6
stevenjb (google-dont-use)
Thanks! lgtm
3 years, 10 months ago (2017-02-17 22:41:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699713007/1
3 years, 10 months ago (2017-02-21 18:19:23 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-21 18:19:25 UTC) #12
hcarmona
Need LG from your @chromium to commit... Please stamp in order to land :-) Thanks!
3 years, 10 months ago (2017-02-21 18:23:22 UTC) #13
stevenjb
On 2017/02/21 18:23:22, hcarmona wrote: > Need LG from your @chromium to commit... > Please ...
3 years, 10 months ago (2017-02-21 18:23:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699713007/1
3 years, 10 months ago (2017-02-21 18:41:22 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 21:41:03 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/946a9f3c1606d0e90b11303580e9...

Powered by Google App Engine
This is Rietveld 408576698