third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations (Closed)

Patch Set: Comments + readability improvements Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index 23c818acc3fd4305d6b23730e4f574f6849ebf88..75a907f320a3de64f857400719e2b9521d4c2d6b 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -625,6 +625,7 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

bool paintRenderingResultsToCanvas(SourceDrawingBuffer) override;

WebLayer* platformLayer() const override;

void stop() override;

+ void finalizeFrame() override;

// DrawingBuffer::Client implementation.

bool DrawingBufferClientIsBoundForDraw() override;

@@ -691,6 +692,7 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

TaskRunnerTimer<WebGLRenderingContextBase> m_restoreTimer;

bool m_markedCanvasDirty;

+ bool m_animationFrameInProgress;

// List of bound VBO's. Used to maintain info about sizes for ARRAY_BUFFER and

// stored values for ELEMENT_ARRAY_BUFFER