third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp - Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp

Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations (Closed)

Patch Set: Comments + readability improvements Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp

index af6226876441d45ffa08a87153fc89501b8b8203..60de38b046fc04cd16847d2296650806738fdbc6 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp

@@ -637,11 +637,11 @@ TEST_F(CanvasRenderingContextUsageTrackingTest, incrementFrameCount) {

createContext(NonOpaque);

EXPECT_EQ(0, context2d()->getUsage().numFramesSinceReset);

- context2d()->incrementFrameCount();

+ context2d()->finalizeFrame();

EXPECT_EQ(1, context2d()->getUsage().numFramesSinceReset);

- context2d()->incrementFrameCount();

+ context2d()->finalizeFrame();

EXPECT_EQ(3, context2d()->getUsage().numFramesSinceReset);

}

@@ -649,8 +649,8 @@ TEST_F(CanvasRenderingContextUsageTrackingTest, resetUsageTracking) {

createContext(NonOpaque);

EXPECT_EQ(0, context2d()->getUsage().numFramesSinceReset);

- context2d()->incrementFrameCount();

+ context2d()->finalizeFrame();

EXPECT_EQ(2, context2d()->getUsage().numFramesSinceReset);

const int numReps = 100;