Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations (Closed)
Patch Set: Comments + readability improvements Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
index b420788e72f6fa6d018efc27dcac81a464d22691..a7bc7ddc4e97f4540a43c2514e2bf9ab22cd826b 100644
--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
@@ -134,6 +134,11 @@ class CORE_EXPORT CanvasRenderingContext
};
virtual void loseContext(LostContextMode) {}
+ // This method gets called at the end of script tasks that modified
+ // the contents of the canvas (called didDraw). It marks the completion
+ // of a presentable frame.
+ virtual void finalizeFrame() {}
+
// WebThread::TaskObserver implementation
void didProcessTask() override;
void willProcessTask() final {}
@@ -157,7 +162,6 @@ class CORE_EXPORT CanvasRenderingContext
virtual String getIdFromControl(const Element* element) { return String(); }
virtual bool isAccelerationOptimalForCanvasContent() const { return true; }
virtual void resetUsageTracking(){};
- virtual void incrementFrameCount(){};
// WebGL-specific interface
virtual bool is3d() const { return false; }

Powered by Google App Engine
This is Rietveld 408576698