third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp - Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations (Closed)

Patch Set: Comments + readability improvements Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

index ce4019c173a0769176bb9d07578c481753834b77..5db6d549ebb8dce8372800b6678c7c54e51b9c49 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

@@ -160,12 +160,11 @@ void CanvasRenderingContext::didProcessTask() {

Platform::current()->currentThread()->removeTaskObserver(this);

m_finalizeFrameScheduled = false;

- if (!canvas())

- return;

// The end of a script task that drew content to the canvas is the point

// at which the current frame may be considered complete.

- canvas()->finalizeFrame();

+ if (canvas())

+ canvas()->finalizeFrame();

+ finalizeFrame();

}

CanvasRenderingContext::ContextType CanvasRenderingContext::contextTypeFromId(