Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations (Closed)
Patch Set: fixed test failures Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
index b420788e72f6fa6d018efc27dcac81a464d22691..7fea769da4afd12a19447739c96e791fd8279c68 100644
--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
@@ -134,6 +134,8 @@ class CORE_EXPORT CanvasRenderingContext
};
virtual void loseContext(LostContextMode) {}
+ virtual void finalizeFrame() {}
Ken Russell (switch to Gerrit) 2017/02/18 00:08:01 Please document this new public method. Who should
Justin Novosad 2017/02/21 18:03:28 Done.
+
// WebThread::TaskObserver implementation
void didProcessTask() override;
void willProcessTask() final {}
@@ -157,7 +159,6 @@ class CORE_EXPORT CanvasRenderingContext
virtual String getIdFromControl(const Element* element) { return String(); }
virtual bool isAccelerationOptimalForCanvasContent() const { return true; }
virtual void resetUsageTracking(){};
- virtual void incrementFrameCount(){};
// WebGL-specific interface
virtual bool is3d() const { return false; }

Powered by Google App Engine
This is Rietveld 408576698