Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

Issue 2699713005: Fix missing finalizeFrame barriers in WebGL animations (Closed)
Patch Set: fixed test failures Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
index ce4019c173a0769176bb9d07578c481753834b77..fe856ad9ed7dc149b5db86bacfad9fe9f7d15183 100644
--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
@@ -166,6 +166,7 @@ void CanvasRenderingContext::didProcessTask() {
// The end of a script task that drew content to the canvas is the point
// at which the current frame may be considered complete.
canvas()->finalizeFrame();
+ finalizeFrame();
Ken Russell (switch to Gerrit) 2017/02/18 00:08:01 Why is this being added here instead of inside HTM
Justin Novosad 2017/02/21 18:06:21 Because not all rendering contexts have an HTMLCan
Ken Russell (switch to Gerrit) 2017/02/21 19:23:10 Ah right. Thanks.
xlai (Olivia) 2017/02/21 19:56:56 What would be the scenarios when finalizeFrame() i
}
CanvasRenderingContext::ContextType CanvasRenderingContext::contextTypeFromId(

Powered by Google App Engine
This is Rietveld 408576698