Should paint border before background when bleedAvoidance is BackgroundBleedBackgroundOverBorder

Source/core/rendering/RenderTable.cpp

Index: Source/core/rendering/RenderTable.cpp
diff --git a/Source/core/rendering/RenderTable.cpp b/Source/core/rendering/RenderTable.cpp
index 3ac6e839dd73e13e59f768d40684bc6ecda40400..57130925a7e2fd90a7a5a3ba9978b0b88e89aeca 100644
--- a/Source/core/rendering/RenderTable.cpp
+++ b/Source/core/rendering/RenderTable.cpp
@@ -729,10 +729,16 @@ void RenderTable::paintBoxDecorations(PaintInfo& paintInfo, const LayoutPoint& p
 
 void RenderTable::paintBackgroundWithBorderAndBoxShadow(PaintInfo& paintInfo, const LayoutRect& rect, BackgroundBleedAvoidance bleedAvoidance)
 {
+    bool needToPaintBorder = !style()->hasAppearance() && style()->hasBorder() && !collapseBorders();
+    // If bleedAvoidance is BackgroundOverBorder, we need to paint borders before painting background.
+    if (bleedAvoidance == BackgroundBleedBackgroundOverBorder && needToPaintBorder)
+        paintBorder(paintInfo, rect, style());

[Julien - ping for review, 2013/10/25 00:29:16]

Other callers pass bleedAvoidance, shouldn't be consistent here and below?

[tasak, 2013/11/27 08:20:44]

Sorry.
The "BackgroundOverBorder" should be "BackgroundBleedBackgroundOverBorder".
It's my mistake.

+
     paintBackground(paintInfo, rect, bleedAvoidance);
     paintBoxShadow(paintInfo, rect, style(), Inset);
 
-    if (bleedAvoidance != BackgroundBleedBackgroundOverBorder && !style()->hasAppearance() && style()->hasBorder() && !collapseBorders())
+    // If bleedAvoidance is not BackgroundOverBorder, we need to paint borders after painting background.
+    if (bleedAvoidance != BackgroundBleedBackgroundOverBorder && needToPaintBorder)
         paintBorder(paintInfo, rect, style());
 }

[Julien - ping for review, 2013/10/25 00:29:16]

This function is now very similar to the one in RenderBox with the only
difference being the collapsedBorder() check.

[tasak, 2013/11/27 08:20:44]

I see. I added collapsedBorder() to RenderBox and made the method virtual.