Should paint border before background when bleedAvoidance is BackgroundBleedBackgroundOverBorder

Source/core/rendering/RenderTable.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 711 matching lines @@
     if (!paintInfo.shouldPaintWithinRoot(this))
         return;
 
     LayoutRect rect(paintOffset, size());
     subtractCaptionRect(rect);
     paintBoxDecorationsWithRect(paintInfo, paintOffset, rect);
 }
 
 void RenderTable::paintBackgroundWithBorderAndBoxShadow(PaintInfo& paintInfo, const LayoutRect& rect, BackgroundBleedAvoidance bleedAvoidance)
 {
+    bool needToPaintBorder = !style()->hasAppearance() && style()->hasBorder() && !collapseBorders();
+    // If bleedAvoidance is BackgroundOverBorder, we need to paint borders before painting background.
+    if (bleedAvoidance == BackgroundBleedBackgroundOverBorder && needToPaintBorder)
+        paintBorder(paintInfo, rect, style());

[Julien - ping for review, 2013/10/25 00:29:16]

Other callers pass bleedAvoidance, shouldn't be consistent here and below?

[tasak, 2013/11/27 08:20:44]

Sorry.
The "BackgroundOverBorder" should be "BackgroundBleedBackgroundOverBorder".
It's my mistake.

+
     paintBackground(paintInfo, rect, bleedAvoidance);
     paintBoxShadow(paintInfo, rect, style(), Inset);
 
-    if (bleedAvoidance != BackgroundBleedBackgroundOverBorder && !style()->hasAppearance() && style()->hasBorder() && !collapseBorders())
+    // If bleedAvoidance is not BackgroundOverBorder, we need to paint borders after painting background.
+    if (bleedAvoidance != BackgroundBleedBackgroundOverBorder && needToPaintBorder)
         paintBorder(paintInfo, rect, style());
 }

[Julien - ping for review, 2013/10/25 00:29:16]

This function is now very similar to the one in RenderBox with the only
difference being the collapsedBorder() check.

[tasak, 2013/11/27 08:20:44]

I see. I added collapsedBorder() to RenderBox and made the method virtual.

 
 void RenderTable::paintMask(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
 {
     if (style()->visibility() != VISIBLE || paintInfo.phase != PaintPhaseMask)
         return;
 
     LayoutRect rect(paintOffset, size());
     subtractCaptionRect(rect);
 
     paintMaskImages(paintInfo, rect);
@@ skipping 694 matching lines @@
 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCell* cell) const
 {
     ASSERT(cell->isFirstOrLastCellInRow());
     if (hasSameDirectionAs(cell->row()))
         return style()->borderEnd();
 
     return style()->borderStart();
 }
 
 }