Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2699673002: [Sensors] Fix error type and message used (Closed)

Created:
3 years, 10 months ago by Mikhail
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Fix error type and message used Before this change Sensor implementation used 'UnknownError' exception type (and the default message) to report errors from mojo proxies. This led to the weird error messages like: "SensorErrorEvent {error: DOMException: An unknown error occurred within Indexed Database.,". This patch uses 'NotReadableError' as described in the specification [1] and also simplifies the error handling code. BUG=692559 [1] https://w3c.github.io/sensors Review-Url: https://codereview.chromium.org/2699673002 Cr-Commit-Position: refs/heads/master@{#450741} Committed: https://chromium.googlesource.com/chromium/src/+/064a292ce35b28592529c5bded26f905d65833a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M third_party/WebKit/Source/modules/sensor/SensorProxy.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.cpp View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Mikhail
PTAL
3 years, 10 months ago (2017-02-15 15:27:22 UTC) #4
haraken
LGTM on my side
3 years, 10 months ago (2017-02-15 15:29:32 UTC) #5
Reilly Grant (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-15 16:57:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699673002/1
3 years, 10 months ago (2017-02-15 17:23:17 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 17:36:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/064a292ce35b28592529c5bded26...

Powered by Google App Engine
This is Rietveld 408576698