Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2699663004: Do not enforce unique package name in gradle projects. (Closed)

Created:
3 years, 10 months ago by sakal-chromium
Modified:
3 years, 10 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not enforce unique package name in gradle projects. This is needed because multiple targets use the default Android manifest with package name "dummy.package". This problem occurs when letting gradle process resources. BUG=682846, webrtc:6328 Review-Url: https://codereview.chromium.org/2699663004 Cr-Commit-Position: refs/heads/master@{#450976} Committed: https://chromium.googlesource.com/chromium/src/+/b4ef9a4857c32338bc7b23e30708871b7541dec0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/gradle/android.jinja View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sakal-chromium
PTAL
3 years, 10 months ago (2017-02-16 10:03:08 UTC) #2
agrieve
On 2017/02/16 10:03:08, sakal-chromium wrote: > PTAL lgtm
3 years, 10 months ago (2017-02-16 15:38:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699663004/1
3 years, 10 months ago (2017-02-16 15:39:44 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 15:50:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4ef9a4857c32338bc7b23e30708...

Powered by Google App Engine
This is Rietveld 408576698