Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: extensions/common/update_manifest.h

Issue 2699663003: Convert utility process extension ParseUpdate IPC to mojo (Closed)
Patch Set: Extensions review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/typemaps.gni ('k') | extensions/common/update_manifest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/update_manifest.h
diff --git a/extensions/common/update_manifest.h b/extensions/common/update_manifest.h
index 6761a399e8d73cb17aa0b4efa00d5abc7ddae3f6..d98586e2cf07dc83b454153d93539cf29d503b83 100644
--- a/extensions/common/update_manifest.h
+++ b/extensions/common/update_manifest.h
@@ -40,6 +40,10 @@ class UpdateManifest {
// a differential update is specified in the response.
// The result of parsing one <app> tag in an xml update check manifest.
+ // TODO(crbug.com/692120): consider removing struct Result and Results and
+ // using the corresponding mojo type instead. This would also remove the
+ // need for the Mojo struct traits that are currently defined / used to
+ // cart these Result/Results structs over Mojo IPC.
struct Result {
Result();
Result(const Result& other);
@@ -64,6 +68,8 @@ class UpdateManifest {
static const int kNoDaystart = -1;
struct Results {
Results();
+ Results(const Results& other);
+ Results& operator=(const Results& other);
~Results();
std::vector<Result> list;
« no previous file with comments | « extensions/common/typemaps.gni ('k') | extensions/common/update_manifest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698