Add high contrast keyboard shortcut to keyboard overlay

Add high contrast keyboard shortcut to keyboard overlay

This CL adds the Search+Shift+H keyboard shortcut (which toggles the
high contrast mode) to the keyboard overlay.

BUG=676510
TEST=manually, open keyboard overlay (Ctrl+Alt+/), and press and hold
Search and Shift. The key H should show "Toggle High Contrast Mode".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2699643004
Cr-Commit-Position: refs/heads/master@{#451186}
Committed: https://chromium.googlesource.com/chromium/src/+/11706d336c17042bfaa75d017a124b85647d4c11

[afakhry, 2017-02-16 00:36:09]

Description was changed from

==========
Add high contrast keyboard shortcut to keyboard overlay

This CL adds the Search+Shift+H keyboard shortcut (which toggles the
high contrast mode) to the keyboard overlay.

BUG=676510
TEST=manually, open keyboard overlay (Ctrl+Alt+/), and press and hold
Search and Shift. The key H should show "Toggle High Contrast Mode".
==========

to

==========
Add high contrast keyboard shortcut to keyboard overlay

This CL adds the Search+Shift+H keyboard shortcut (which toggles the
high contrast mode) to the keyboard overlay.

BUG=676510
TEST=manually, open keyboard overlay (Ctrl+Alt+/), and press and hold
Search and Shift. The key H should show "Toggle High Contrast Mode".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-02-16 00:36:40]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 00:38:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-02-16 00:39:30]

Patchset #1 (id:1) has been deleted

[afakhry, 2017-02-16 00:41:10]

afakhry@chromium.org changed reviewers:
+ stevenjb@chromium.org

[afakhry, 2017-02-16 00:41:11]

Steven, could you please review this CL? Thanks!

[stevenjb, 2017-02-16 19:45:13]

lgtm with string confirmation or change.

https://codereview.chromium.org/2699643004/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2699643004/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:4853: Toggle High Contrast Mode
Please double check this with UX (I would expect just 'High contrast mode')

[afakhry, 2017-02-16 21:07:44]

https://codereview.chromium.org/2699643004/diff/20001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2699643004/diff/20001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:4853: Toggle High Contrast Mode
On 2017/02/16 19:45:13, stevenjb wrote:
> Please double check this with UX (I would expect just 'High contrast mode')

This is how dmazzoni wrote it when the shortcut used to be Ctrl+Alt+H, but that
was reverted 5 months ago.

[dmazzoni, 2017-02-16 21:18:56]

On 2017/02/16 21:07:44, afakhry wrote:
>
https://codereview.chromium.org/2699643004/diff/20001/chrome/app/chromeos_str...
> File chrome/app/chromeos_strings.grdp (right):
> 
>
https://codereview.chromium.org/2699643004/diff/20001/chrome/app/chromeos_str...
> chrome/app/chromeos_strings.grdp:4853: Toggle High Contrast Mode
> On 2017/02/16 19:45:13, stevenjb wrote:
> > Please double check this with UX (I would expect just 'High contrast mode')
> 
> This is how dmazzoni wrote it when the shortcut used to be Ctrl+Alt+H, but
that
> was reverted 5 months ago.

Yeah, I think "Toggle" is important, it matches other shortcuts that Toggle.

Thanks for updating the keyboard overlay!

[afakhry, 2017-02-16 22:21:32]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2017-02-16 22:22:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:24:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487283692079500,
"parent_rev": "29dbad12b55c8d2d520b26987735354c25b9590c", "commit_rev":
"11706d336c17042bfaa75d017a124b85647d4c11"}

[commit-bot: I haz the power, 2017-02-17 02:24:53]

Description was changed from

==========
Add high contrast keyboard shortcut to keyboard overlay

This CL adds the Search+Shift+H keyboard shortcut (which toggles the
high contrast mode) to the keyboard overlay.

BUG=676510
TEST=manually, open keyboard overlay (Ctrl+Alt+/), and press and hold
Search and Shift. The key H should show "Toggle High Contrast Mode".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add high contrast keyboard shortcut to keyboard overlay

This CL adds the Search+Shift+H keyboard shortcut (which toggles the
high contrast mode) to the keyboard overlay.

BUG=676510
TEST=manually, open keyboard overlay (Ctrl+Alt+/), and press and hold
Search and Shift. The key H should show "Toggle High Contrast Mode".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2699643004
Cr-Commit-Position: refs/heads/master@{#451186}
Committed:
https://chromium.googlesource.com/chromium/src/+/11706d336c17042bfaa75d017a12...
==========

[commit-bot: I haz the power, 2017-02-17 02:24:55]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/11706d336c17042bfaa75d017a12...