Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2699643003: Show an infobar when VR services need to be installed or updated. (Closed)
Patch Set: Add install vs update check, final icon resources. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index 1dd39073127dff1104478551e8084d4945080c02..bebd331d22fe5fd931f64a4d25c442fa81586bde 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -2738,6 +2738,17 @@ You can control the Physical Web in Chrome Settings.
<message name="IDS_KEYBOARD_SHORTCUT_WEBPAGE_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to manipulation of the current tab window. This group is part of several groups of keyboard shortcuts all shown in a dialog.">
Webpage shortcuts
</message>
+
+ <!-- VR services check infobar -->
+ <message name="IDS_VR_SERVICES_CHECK_INFOBAR_TEXT" desc="Text to displayed in the VR Services check infobar.">
+ To view virtual reality content, <ph name="ACTION">%s<ex>install</ex></ph> Google VR Services
+ </message>
+ <message name="IDS_VR_SERVICES_CHECK_INFOBAR_INSTALL_ACTION" desc="Text to be displayed in the VR Services check infobar text and confirm button for the install action">
+ install
Bernhard Bauer 2017/02/16 12:12:51 According to https://material.io/guidelines/compon
amp 2017/02/16 18:41:35 I wondered if there might be some rule like that.
amp 2017/02/17 01:50:39 Done.
Bernhard Bauer 2017/02/17 16:14:16 No, you don't need the full capitalization for the
+ </message>
+ <message name="IDS_VR_SERVICES_CHECK_INFOBAR_UPDATE_ACTION" desc="Text to be displayed in the VR Services check infobar text and confirm button for the update action">
+ update
+ </message>
</messages>
</release>
</grit>

Powered by Google App Engine
This is Rietveld 408576698