chrome/android/java/strings/android_chrome_strings.grd - Issue 2699643003: Show an infobar when VR services need to be installed or updated.

Side by Side Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2699643003: Show an infobar when VR services need to be installed or updated. (Closed)

Patch Set: Add install vs update check, final icon resources. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | components/infobars/core/infobar_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2	2

3 <!-- android_chrome_strings.grd contains strings for Chrome for Android.	3 <!-- android_chrome_strings.grd contains strings for Chrome for Android.

4	4

5 FAQ:	5 FAQ:

6 - How do I add, change, or remove a string?	6 - How do I add, change, or remove a string?

7 Just update this file.	7 Just update this file.

8 - Translations will happen automatically??	8 - Translations will happen automatically??

9 Yes, indeed. Just add your string before the branch point and	9 Yes, indeed. Just add your string before the branch point and

10 make the description good.	10 make the description good.

(...skipping 2720 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2731 </message>	2731 </message>

2732 <message name="IDS_KEYBOARD_SHORTCUT_TAB_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to the tab window. This group is part of several groups of keyboard shortcuts all shown in a dialog.">	2732 <message name="IDS_KEYBOARD_SHORTCUT_TAB_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to the tab window. This group is part of several groups of keyboard shortcuts all shown in a dialog.">

2733 Tab and window shortcuts	2733 Tab and window shortcuts

2734 </message>	2734 </message>

2735 <message name="IDS_KEYBOARD_SHORTCUT_CHROME_FEATURE_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to the Chrome app features. This group is part of several groups of keyboard shortcuts all sh own in a dialog.">	2735 <message name="IDS_KEYBOARD_SHORTCUT_CHROME_FEATURE_GROUP_HEADER" desc="A text label that appears above a list of shortcuts that are related to the Chrome app features. This group is part of several groups of keyboard shortcuts all sh own in a dialog.">

2736 Google Chrome feature shortcuts	2736 Google Chrome feature shortcuts

2737 </message>	2737 </message>

2738 <message name="IDS_KEYBOARD_SHORTCUT_WEBPAGE_GROUP_HEADER" desc="A text la bel that appears above a list of shortcuts that are related to manipulation of t he current tab window. This group is part of several groups of keyboard shortcut s all shown in a dialog.">	2738 <message name="IDS_KEYBOARD_SHORTCUT_WEBPAGE_GROUP_HEADER" desc="A text la bel that appears above a list of shortcuts that are related to manipulation of t he current tab window. This group is part of several groups of keyboard shortcut s all shown in a dialog.">

2739 Webpage shortcuts	2739 Webpage shortcuts

2740 </message>	2740 </message>

	2741

	2742 <!-- VR services check infobar -->

	2743 <message name="IDS_VR_SERVICES_CHECK_INFOBAR_TEXT" desc="Text to displayed in the VR Services check infobar.">

	2744 To view virtual reality content, <ph name="ACTION">%s<ex>install</ex></p h> Google VR Services

	2745 </message>

	2746 <message name="IDS_VR_SERVICES_CHECK_INFOBAR_INSTALL_ACTION" desc="Text to be displayed in the VR Services check infobar text and confirm button for the i nstall action">

	2747 install
	Bernhard Bauer 2017/02/16 12:12:51 According to https://material.io/guidelines/compon According to https://material.io/guidelines/components/buttons.html#buttons-style, text on buttons should be capitalized (even if the button happens to render the text in all-caps). amp 2017/02/16 18:41:35 I wondered if there might be some rule like that. Show quoted text On 2017/02/16 12:12:51, Bernhard Bauer wrote: > According to > https://material.io/guidelines/components/buttons.html#buttons-style, text on > buttons should be capitalized (even if the button happens to render the text in > all-caps). I wondered if there might be some rule like that. Thanks for the clarification. So I'll go ahead and make 4 entries, 2 for the lower case used in the infobar text, and 2 for the buttons which will be the same thing, just upper case. Is that the right way to do something like this? amp 2017/02/17 01:50:39 Done. Show quoted text On 2017/02/16 18:41:35, amp wrote: > On 2017/02/16 12:12:51, Bernhard Bauer wrote: > > According to > > https://material.io/guidelines/components/buttons.html#buttons-style, text on > > buttons should be capitalized (even if the button happens to render the text > in > > all-caps). > > I wondered if there might be some rule like that. Thanks for the clarification. > > So I'll go ahead and make 4 entries, 2 for the lower case used in the infobar > text, and 2 for the buttons which will be the same thing, just upper case. Is > that the right way to do something like this? Done. Bernhard Bauer 2017/02/17 16:14:16 No, you don't need the full capitalization for the Show quoted text On 2017/02/16 18:41:35, amp wrote: > On 2017/02/16 12:12:51, Bernhard Bauer wrote: > > According to > > https://material.io/guidelines/components/buttons.html#buttons-style, text on > > buttons should be capitalized (even if the button happens to render the text > in > > all-caps). > > I wondered if there might be some rule like that. Thanks for the clarification. > > So I'll go ahead and make 4 entries, 2 for the lower case used in the infobar > text, and 2 for the buttons which will be the same thing, just upper case. Is > that the right way to do something like this? No, you don't need the full capitalization for the button, as the UI will do that. What I would do however is split the IDS_VR_SERVICES_CHECK_INFOBAR_TEXT pattern up into two full strings -- it's only marginally bigger (which might be compressed away anyway) and reduces the chance for translation mistakes.
	2748 </message>

	2749 <message name="IDS_VR_SERVICES_CHECK_INFOBAR_UPDATE_ACTION" desc="Text to be displayed in the VR Services check infobar text and confirm button for the up date action">

	2750 update

	2751 </message>

2741 </messages>	2752 </messages>

2742 </release>	2753 </release>

2743 </grit>	2754 </grit>

OLD	NEW