Move WebpDecoder from ios/web to components/image_fetcher

Move WebpDecoder from ios/web to components/image_fetcher

As iOS now use the ImageFetcher from components, the WebPDecoder should also
live in components/image_fetcher/ios.

BUG=683918
Review-Url: https://codereview.chromium.org/2699633006
Cr-Commit-Position: refs/heads/master@{#451596}
Committed: https://chromium.googlesource.com/chromium/src/+/a1313959f214f8eea4efa3fd9fe6ed0ee7cffaf1

[gambard, 2017-02-17 09:14:45]

gambard@chromium.org changed reviewers:
+ sdefresne@chromium.org, urvang@chromium.org

[gambard, 2017-02-17 09:14:46]

PTAL.
+urvang@ for the DEPS include of third_party/libwebp (moved from
ios/web/public/image_fetcher to components/image_fetcher/ios).

[sdefresne, 2017-02-17 10:29:39]

Can you send this to the ios-simulator try bot? I want to check that the test
resources are correctly found when running the test.

[gambard, 2017-02-17 10:31:04]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 10:31:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 10:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 10:33:34]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gambard, 2017-02-17 16:15:50]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 16:16:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 16:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 16:19:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[urvang, 2017-02-17 18:13:16]

On 2017/02/17 10:29:39, sdefresne wrote:
> Can you send this to the ios-simulator try bot? I want to check that the test
> resources are correctly found when running the test.

LGTM for libwebp include in DEPS.

[gambard, 2017-02-20 07:51:00]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 07:51:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gambard, 2017-02-20 09:52:25]

sdefresne: bot cleared, PTAL.

[sdefresne, 2017-02-20 09:56:23]

lgtm

https://codereview.chromium.org/2699633006/diff/50001/components/image_fetche...
File components/image_fetcher/ios/webp_decoder.mm (right):

https://codereview.chromium.org/2699633006/diff/50001/components/image_fetche...
components/image_fetcher/ios/webp_decoder.mm:9: #include <stdint.h>
nit: blank line to separate system Objective-C headers from system C headers

https://codereview.chromium.org/2699633006/diff/50001/components/image_fetche...
File components/image_fetcher/ios/webp_decoder_unittest.mm (right):

https://codereview.chromium.org/2699633006/diff/50001/components/image_fetche...
components/image_fetcher/ios/webp_decoder_unittest.mm:9: #include <stddef.h>
nit: blank line to separate system Objective-C headers from system C headers

[commit-bot: I haz the power, 2017-02-20 10:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 10:02:59]

Dry run: This issue passed the CQ dry run.

[gambard, 2017-02-20 10:08:50]

Thanks!

https://codereview.chromium.org/2699633006/diff/50001/components/image_fetche...
File components/image_fetcher/ios/webp_decoder.mm (right):

https://codereview.chromium.org/2699633006/diff/50001/components/image_fetche...
components/image_fetcher/ios/webp_decoder.mm:9: #include <stdint.h>
On 2017/02/20 09:56:23, sdefresne wrote:
> nit: blank line to separate system Objective-C headers from system C headers

Done.

https://codereview.chromium.org/2699633006/diff/50001/components/image_fetche...
File components/image_fetcher/ios/webp_decoder_unittest.mm (right):

https://codereview.chromium.org/2699633006/diff/50001/components/image_fetche...
components/image_fetcher/ios/webp_decoder_unittest.mm:9: #include <stddef.h>
On 2017/02/20 09:56:23, sdefresne wrote:
> nit: blank line to separate system Objective-C headers from system C headers

Done.

[gambard, 2017-02-20 10:08:54]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-02-20 10:08:55]

The patchset sent to the CQ was uploaded after l-g-t-m from urvang@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2699633006/#ps70001
(title: "Separate header")

[commit-bot: I haz the power, 2017-02-20 10:09:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 11:28:35]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1487585334914800,
"parent_rev": "e859ab1300be6e103b62bc5409214e5584287815", "commit_rev":
"a1313959f214f8eea4efa3fd9fe6ed0ee7cffaf1"}

[commit-bot: I haz the power, 2017-02-20 11:29:13]

Description was changed from

==========
Move WebpDecoder from ios/web to components/image_fetcher

As iOS now use the ImageFetcher from components, the WebPDecoder should also
live in components/image_fetcher/ios.

BUG=683918
==========

to

==========
Move WebpDecoder from ios/web to components/image_fetcher

As iOS now use the ImageFetcher from components, the WebPDecoder should also
live in components/image_fetcher/ios.

BUG=683918

Review-Url: https://codereview.chromium.org/2699633006
Cr-Commit-Position: refs/heads/master@{#451596}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1313959f214f8eea4efa3fd9fe6...
==========

[commit-bot: I haz the power, 2017-02-20 11:29:14]

Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/a1313959f214f8eea4efa3fd9fe6...