|
|
Chromium Code Reviews|
Created:
3 years, 10 months ago by DaleCurtis Modified:
3 years, 10 months ago Reviewers:
liberato (no reviews please) CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionIssue a parse error on unexpected negative timestamps.
We should not pass such buffers outside of FFmpegDemuxer.
BUG=686482
TEST=new unittest.
Review-Url: https://codereview.chromium.org/2699563002
Cr-Commit-Position: refs/heads/master@{#451172}
Committed: https://chromium.googlesource.com/chromium/src/+/25d15671d9766d5f3cb87b7f5ff810cca5b130e9
Patch Set 1 #Patch Set 2 : Only fail after rebasing timestamps. #Patch Set 3 : Rebase. #
Messages
Total messages: 27 (14 generated)
dalecurtis@chromium.org changed reviewers: + liberato@chromium.org
lgtm
lgtm
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by dalecurtis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from liberato@chromium.org Link to the patchset: https://codereview.chromium.org/2699563002/#ps20001 (title: "Only fail after rebasing timestamps.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dalecurtis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from liberato@chromium.org Link to the patchset: https://codereview.chromium.org/2699563002/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487291020741210,
"parent_rev": "1dd4ccf354c3286647e35ed6e02c36de695901fc", "commit_rev":
"25d15671d9766d5f3cb87b7f5ff810cca5b130e9"}
Message was sent while issue was closed.
Description was changed from ========== Issue a parse error on unexpected negative timestamps. We should not pass such buffers outside of FFmpegDemuxer. BUG=686482 TEST=new unittest. ========== to ========== Issue a parse error on unexpected negative timestamps. We should not pass such buffers outside of FFmpegDemuxer. BUG=686482 TEST=new unittest. Review-Url: https://codereview.chromium.org/2699563002 Cr-Commit-Position: refs/heads/master@{#451172} Committed: https://chromium.googlesource.com/chromium/src/+/25d15671d9766d5f3cb87b7f5ff8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/25d15671d9766d5f3cb87b7f5ff8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
