Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2699563002: Issue a parse error on unexpected negative timestamps. (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Issue a parse error on unexpected negative timestamps. We should not pass such buffers outside of FFmpegDemuxer. BUG=686482 TEST=new unittest. Review-Url: https://codereview.chromium.org/2699563002 Cr-Commit-Position: refs/heads/master@{#451172} Committed: https://chromium.googlesource.com/chromium/src/+/25d15671d9766d5f3cb87b7f5ff810cca5b130e9

Patch Set 1 #

Patch Set 2 : Only fail after rebasing timestamps. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M media/filters/ffmpeg_demuxer.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 2 chunks +7 lines, -10 lines 0 comments Download
A media/test/data/negative_ts.flac View Binary file 0 comments Download

Messages

Total messages: 27 (14 generated)
DaleCurtis
3 years, 10 months ago (2017-02-14 23:43:03 UTC) #2
liberato (no reviews please)
lgtm
3 years, 10 months ago (2017-02-15 05:26:46 UTC) #3
liberato (no reviews please)
lgtm
3 years, 10 months ago (2017-02-15 05:26:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699563002/1
3 years, 10 months ago (2017-02-15 07:46:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/310059)
3 years, 10 months ago (2017-02-15 08:23:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699563002/20001
3 years, 10 months ago (2017-02-15 23:44:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/212157) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 10 months ago (2017-02-16 00:16:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699563002/40001
3 years, 10 months ago (2017-02-16 02:39:49 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/367567)
3 years, 10 months ago (2017-02-16 04:03:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699563002/40001
3 years, 10 months ago (2017-02-16 04:17:14 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-16 06:19:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699563002/40001
3 years, 10 months ago (2017-02-17 00:24:59 UTC) #24
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 01:59:57 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/25d15671d9766d5f3cb87b7f5ff8...

Powered by Google App Engine
This is Rietveld 408576698