Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2699543002:
cros: Turn on close() tracking on dev (Closed)
|
Created:
3 years, 10 months ago by xiyuan Modified:
3 years, 10 months ago Reviewers:
Daniel Erat CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncros: Turn on close() tracking on dev
BUG=660960
Review-Url: https://codereview.chromium.org/2699543002
Cr-Commit-Position: refs/heads/master@{#450720}
Committed: https://chromium.googlesource.com/chromium/src/+/806c783b597a849944ca6eb0c5922bbca35027c2
Patch Set 1 #
Total comments: 2
Patch Set 2 : update comments #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run
xiyuan@chromium.org changed reviewers: + derat@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2699543002/diff/1/chrome/browser/chromeos/chr... File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://codereview.chromium.org/2699543002/diff/1/chrome/browser/chromeos/chr... chrome/browser/chromeos/chrome_browser_main_chromeos.cc:372: // Enable libc close tracking in browser process on unknown/canary channel for nit: update this comment (maybe to omit the channel names, since it's obvious what it's doing from the code): // Crash on libc double-close() to try to track down bugs: http://crbug.com/660960
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2699543002/diff/1/chrome/browser/chromeos/chr... File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://codereview.chromium.org/2699543002/diff/1/chrome/browser/chromeos/chr... chrome/browser/chromeos/chrome_browser_main_chromeos.cc:372: // Enable libc close tracking in browser process on unknown/canary channel for On 2017/02/14 23:01:11, Daniel Erat wrote: > nit: update this comment (maybe to omit the channel names, since it's obvious > what it's doing from the code): > > // Crash on libc double-close() to try to track down bugs: > http://crbug.com/660960 Good point. Done.
The CQ bit was checked by xiyuan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org Link to the patchset: https://codereview.chromium.org/2699543002/#ps20001 (title: "update comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiyuan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487173948545100,
"parent_rev": "208db36c6e63597bbd5d6e849b63628d75895609", "commit_rev":
"806c783b597a849944ca6eb0c5922bbca35027c2"}
Message was sent while issue was closed.
Description was changed from ========== cros: Turn on close() tracking on dev BUG=660960 ========== to ========== cros: Turn on close() tracking on dev BUG=660960 Review-Url: https://codereview.chromium.org/2699543002 Cr-Commit-Position: refs/heads/master@{#450720} Committed: https://chromium.googlesource.com/chromium/src/+/806c783b597a849944ca6eb0c592... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/806c783b597a849944ca6eb0c592... |
