Add an option to print the resource ids that Chrome loads.

Add an option to print the resource ids that Chrome loads.

This output will be used to re-order Chrome's resources to improve
startup time.

BUG=692670
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2699513002
Cr-Commit-Position: refs/heads/master@{#451463}
Committed: https://chromium.googlesource.com/chromium/src/+/8a40fe5f00e8b6c3363194f69fe9b2b4f79781b8

[Alexei Svitkine (slow), 2017-02-14 21:22:39]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 21:23:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 21:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:26:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Alexei Svitkine (slow), 2017-02-14 22:32:51]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[Alexei Svitkine (slow), 2017-02-14 22:32:53]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-14 22:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 22:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:37:02]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Alexei Svitkine (slow), 2017-02-16 16:15:31]

Patchset #3 (id:60001) has been deleted

[Alexei Svitkine (slow), 2017-02-16 16:15:40]

Patchset #1 (id:20001) has been deleted

[Alexei Svitkine (slow), 2017-02-16 16:15:47]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[Alexei Svitkine (slow), 2017-02-16 16:15:50]

Patchset #1 (id:40001) has been deleted

[Alexei Svitkine (slow), 2017-02-16 16:15:59]

Description was changed from

==========
Add an option to print the resource ids that Chrome loads.

This output will be used to re-order Chrome's resources to improve
startup time.

BUG=
==========

to

==========
Add an option to print the resource ids that Chrome loads.

This output will be used to re-order Chrome's resources to improve
startup time.

BUG=692670
==========

[commit-bot: I haz the power, 2017-02-16 16:16:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-02-16 16:17:38]

Patchset #1 (id:80001) has been deleted

[Alexei Svitkine (slow), 2017-02-16 16:19:19]

asvitkine@chromium.org changed reviewers:
+ thakis@chromium.org

[Alexei Svitkine (slow), 2017-02-16 16:19:20]

https://codereview.chromium.org/2699513002/diff/100001/ui/base/resource/data_...
File ui/base/resource/data_pack.cc (right):

https://codereview.chromium.org/2699513002/diff/100001/ui/base/resource/data_...
ui/base/resource/data_pack.cc:73: // tools/gritsettings/README.md for more info.
Note: tools/gritsettings/README.md will be added in a future CL - as it also
needs to mention a Python script  that doesn't exist yet. Both of those will be
added in the same future CL.

[Alexei Svitkine (slow), 2017-02-17 15:35:04]

Patchset #3 (id:140001) has been deleted

[Nico, 2017-02-17 21:45:58]

https://codereview.chromium.org/2699513002/diff/120001/ui/base/resource/data_...
File ui/base/resource/data_pack.cc (right):

https://codereview.chromium.org/2699513002/diff/120001/ui/base/resource/data_...
ui/base/resource/data_pack.cc:91: if (!base::ContainsKey(*resource_ids_logged,
resource_id)) {
is it guaranteed that we only load resources from a single thread?

[Alexei Svitkine (slow), 2017-02-17 22:28:52]

Patchset #3 (id:160001) has been deleted

[Alexei Svitkine (slow), 2017-02-17 22:30:44]

https://codereview.chromium.org/2699513002/diff/120001/ui/base/resource/data_...
File ui/base/resource/data_pack.cc (right):

https://codereview.chromium.org/2699513002/diff/120001/ui/base/resource/data_...
ui/base/resource/data_pack.cc:91: if (!base::ContainsKey(*resource_ids_logged,
resource_id)) {
On 2017/02/17 21:45:58, Nico wrote:
> is it guaranteed that we only load resources from a single thread?

Good point. I had originally assumed yes, but looking at the header, there is no
such guarantee provided and looking at the implementation, all the functions are
const and just read the data - so it should in theory be useable from multiple
threads after initial construction.

So given the above, I've now added a lock to this function to safeguard against
potential multi-thread access.

[Nico, 2017-02-17 23:24:18]

lgtm

[Alexei Svitkine (slow), 2017-02-17 23:34:03]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:36:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:39:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:39:17]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Alexei Svitkine (slow), 2017-02-18 02:02:50]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:04:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 04:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 04:02:58]

Exceeded global retry quota

[Alexei Svitkine (slow), 2017-02-18 13:11:30]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-18 13:11:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 13:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 13:18:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexei Svitkine (slow), 2017-02-18 15:28:52]

asvitkine@chromium.org changed reviewers:
+ jochen@chromium.org

[Alexei Svitkine (slow), 2017-02-18 15:28:53]

TBR jochen for trivial change to PRESUBMIT.py

[Alexei Svitkine (slow), 2017-02-18 15:29:34]

Description was changed from

==========
Add an option to print the resource ids that Chrome loads.

This output will be used to re-order Chrome's resources to improve
startup time.

BUG=692670
==========

to

==========
Add an option to print the resource ids that Chrome loads.

This output will be used to re-order Chrome's resources to improve
startup time.

BUG=692670
TBR=jochen@chromium.org
==========

[Alexei Svitkine (slow), 2017-02-18 15:31:32]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-18 15:31:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 15:35:04]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1487431892126610,
"parent_rev": "9d4e3df6e621c6bd80dfaee7008b3e33d0c4fe79", "commit_rev":
"8a40fe5f00e8b6c3363194f69fe9b2b4f79781b8"}

[commit-bot: I haz the power, 2017-02-18 15:35:48]

Description was changed from

==========
Add an option to print the resource ids that Chrome loads.

This output will be used to re-order Chrome's resources to improve
startup time.

BUG=692670
TBR=jochen@chromium.org
==========

to

==========
Add an option to print the resource ids that Chrome loads.

This output will be used to re-order Chrome's resources to improve
startup time.

BUG=692670
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2699513002
Cr-Commit-Position: refs/heads/master@{#451463}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a40fe5f00e8b6c3363194f69fe9...
==========

[commit-bot: I haz the power, 2017-02-18 15:35:49]

Committed patchset #3 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/8a40fe5f00e8b6c3363194f69fe9...

[findit-for-me, 2017-02-18 19:54:33]

FYI: Findit identified this CL at revision 451463 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...