Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2699493002: Add tdanderson to ash/system/OWNERS (Closed)

Created:
3 years, 10 months ago by James Cook
Modified:
3 years, 10 months ago
Reviewers:
tdanderson, stevenjb
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tdanderson to ash/system/OWNERS BUG=none TEST=none Review-Url: https://codereview.chromium.org/2699493002 Cr-Commit-Position: refs/heads/master@{#450502} Committed: https://chromium.googlesource.com/chromium/src/+/877232051110caf21cfed300371fdadf7cea6ffe

Patch Set 1 #

Total comments: 1

Patch Set 2 : single file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M ash/common/system/OWNERS View 1 1 chunk +1 line, -7 lines 0 comments Download
M ash/system/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
James Cook
stevenjb, tdanderson PTAL
3 years, 10 months ago (2017-02-14 20:43:56 UTC) #2
stevenjb
lgtm with or without suggestion https://codereview.chromium.org/2699493002/diff/1/ash/system/OWNERS File ash/system/OWNERS (right): https://codereview.chromium.org/2699493002/diff/1/ash/system/OWNERS#newcode6 ash/system/OWNERS:6: # For UI changes ...
3 years, 10 months ago (2017-02-14 20:49:02 UTC) #3
James Cook
stevenjb, tdanderson, please take another look. //ash/common/system will be collapsed into //ash/system in the next ...
3 years, 10 months ago (2017-02-14 21:16:51 UTC) #5
tdanderson
LGTM
3 years, 10 months ago (2017-02-14 21:32:46 UTC) #6
stevenjb
lgtm
3 years, 10 months ago (2017-02-14 22:24:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699493002/20001
3 years, 10 months ago (2017-02-14 22:36:16 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 23:06:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/877232051110caf21cfed300371f...

Powered by Google App Engine
This is Rietveld 408576698