Deprecate ContentSubresourceFilterDriver.

Deprecate ContentSubresourceFilterDriver.

The driver is no longer used to mock out activation in tests, and otherwise it
had exactly one method. This method is now inlined into the
ContentSubresourceFilterDriverFactory, which, eventually, will itself be
renamed ContentSubresourceFilterDriver.

This CL also removes superfluous calls to GetMaximumActivationState().

BUG=637415
Review-Url: https://codereview.chromium.org/2699443006
Cr-Commit-Position: refs/heads/master@{#451476}
Committed: https://chromium.googlesource.com/chromium/src/+/8fc480797adb8b57f4dada238f2d85c0fe42115b

[engedy, 2017-02-15 19:12:19]

Description was changed from

==========
Deprecate ContentSubresourceFilterDriver.

The driver is no longer used to mock out activation in tests, and otherwise it
had exactly one method. This method is now inlined into the
ContentSubresourceFilterDriverFactory, which, eventually, will itself be
renamed ContentSubresourceFilterDriver.

BUG=637415
==========

to

==========
Deprecate ContentSubresourceFilterDriver.

The driver is no longer used to mock out activation in tests, and otherwise it
had exactly one method. This method is now inlined into the
ContentSubresourceFilterDriverFactory, which, eventually, will itself be
renamed ContentSubresourceFilterDriver.

BUG=637415
==========

[engedy, 2017-02-15 19:12:20]

engedy@chromium.org changed reviewers:
+ csharrison@chromium.org

[engedy, 2017-02-15 19:12:31]

@Charlie, final one, please take a look.

[engedy, 2017-02-15 19:14:02]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 19:15:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-02-15 19:22:24]

LGTM with one question.

https://codereview.chromium.org/2699443006/diff/1/components/subresource_filt...
File
components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
(right):

https://codereview.chromium.org/2699443006/diff/1/components/subresource_filt...
components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc:169:
render_frame_host->GetRoutingID(), activation_level_,
Is removing GetMaximumActivationLevel here just a cleanup? Why was this not
originally activation_level_?

[commit-bot: I haz the power, 2017-02-15 21:26:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:26:26]

Dry run: This issue passed the CQ dry run.

[engedy, 2017-02-15 21:36:10]

Description was changed from

==========
Deprecate ContentSubresourceFilterDriver.

The driver is no longer used to mock out activation in tests, and otherwise it
had exactly one method. This method is now inlined into the
ContentSubresourceFilterDriverFactory, which, eventually, will itself be
renamed ContentSubresourceFilterDriver.

BUG=637415
==========

to

==========
Deprecate ContentSubresourceFilterDriver.

The driver is no longer used to mock out activation in tests, and otherwise it
had exactly one method. This method is now inlined into the
ContentSubresourceFilterDriverFactory, which, eventually, will itself be
renamed ContentSubresourceFilterDriver.

This CL also removes superfluous calls to GetMaximumActivationState().

BUG=637415
==========

[engedy, 2017-02-15 21:36:55]

https://codereview.chromium.org/2699443006/diff/1/components/subresource_filt...
File
components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
(right):

https://codereview.chromium.org/2699443006/diff/1/components/subresource_filt...
components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc:169:
render_frame_host->GetRoutingID(), activation_level_,
On 2017/02/15 19:22:23, Charlie Harrison wrote:
> Is removing GetMaximumActivationLevel here just a cleanup? Why was this not
> originally activation_level_?

Yes, the two should always have the same value, so I thought I might as well
clean it up, because calling the helper involves locking, and I was too lazy to
split this one line change into yet another CL.

Thanks for spotting that, though. I will add this to the CL description.

[engedy, 2017-02-17 19:36:20]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:37:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 20:38:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:38:36]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[engedy, 2017-02-17 21:20:07]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2017-02-17 21:20:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:24:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Charlie Harrison, 2017-02-17 23:31:33]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:33:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:56:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:56:09]

Failed to apply patch for
components/subresource_filter/content/renderer/subresource_filter_agent.h:
While running git apply --index -p1;
  error: patch failed:
components/subresource_filter/content/renderer/subresource_filter_agent.h:26
  error:
components/subresource_filter/content/renderer/subresource_filter_agent.h: patch
does not apply

Patch:      
components/subresource_filter/content/renderer/subresource_filter_agent.h
Index: components/subresource_filter/content/renderer/subresource_filter_agent.h
diff --git
a/components/subresource_filter/content/renderer/subresource_filter_agent.h
b/components/subresource_filter/content/renderer/subresource_filter_agent.h
index
0a72abe290d6f1ea0dc4b647cfab09f663dd5604..c2465e42c2f768dd3cd96d3de712e4bc35da85e1
100644
--- a/components/subresource_filter/content/renderer/subresource_filter_agent.h
+++ b/components/subresource_filter/content/renderer/subresource_filter_agent.h
@@ -26,10 +26,10 @@ namespace subresource_filter {
 class UnverifiedRulesetDealer;
 class DocumentSubresourceFilter;
 
-// The renderer-side agent of the ContentSubresourceFilterDriver. There is one
-// instance per RenderFrame, responsible for setting up the subresource filter
-// for the ongoing provisional document load in the frame when instructed to do
-// so by the driver.
+// The renderer-side agent of ContentSubresourceFilterDriverFactory. There is
+// one instance per RenderFrame, responsible for setting up the subresource
+// filter for the ongoing provisional document load in the frame when
instructed
+// to do so by the driver.
 class SubresourceFilterAgent
     : public content::RenderFrameObserver,
       public base::SupportsWeakPtr<SubresourceFilterAgent> {

[engedy, 2017-02-18 16:51:39]

The CQ bit was checked by engedy@chromium.org

[engedy, 2017-02-18 16:51:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2699443006/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-02-18 16:51:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 17:54:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487436699680970,
"parent_rev": "9b52361723011c5706018aa68e711c9c3b205d33", "commit_rev":
"8fc480797adb8b57f4dada238f2d85c0fe42115b"}

[commit-bot: I haz the power, 2017-02-18 17:55:07]

Description was changed from

==========
Deprecate ContentSubresourceFilterDriver.

The driver is no longer used to mock out activation in tests, and otherwise it
had exactly one method. This method is now inlined into the
ContentSubresourceFilterDriverFactory, which, eventually, will itself be
renamed ContentSubresourceFilterDriver.

This CL also removes superfluous calls to GetMaximumActivationState().

BUG=637415
==========

to

==========
Deprecate ContentSubresourceFilterDriver.

The driver is no longer used to mock out activation in tests, and otherwise it
had exactly one method. This method is now inlined into the
ContentSubresourceFilterDriverFactory, which, eventually, will itself be
renamed ContentSubresourceFilterDriver.

This CL also removes superfluous calls to GetMaximumActivationState().

BUG=637415

Review-Url: https://codereview.chromium.org/2699443006
Cr-Commit-Position: refs/heads/master@{#451476}
Committed:
https://chromium.googlesource.com/chromium/src/+/8fc480797adb8b57f4dada238f2d...
==========

[commit-bot: I haz the power, 2017-02-18 17:55:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8fc480797adb8b57f4dada238f2d...