Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2699443005: Make the settings link in the sync confirmation dialog point to Chrome settings. (Closed)

Created:
3 years, 10 months ago by msarda
Modified:
3 years, 10 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the settings link in the sync confirmation dialog point to Chrome settings. This CL changes the settings link in the confirmation dialog to point to Chrome settings. This ensures that if the user drags and drops this link in the Chrome tab strip, then the Chrome settings will open (which is the right approach). BUG=691957 Review-Url: https://codereview.chromium.org/2699443005 Cr-Commit-Position: refs/heads/master@{#452073} Committed: https://chromium.googlesource.com/chromium/src/+/028db2b1bf62a5ce0574b3c1e7f42e42607cb242

Patch Set 1 #

Patch Set 2 : prepare for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
msarda
Please take a look.
3 years, 10 months ago (2017-02-15 15:29:30 UTC) #5
anthonyvd
lgtm
3 years, 10 months ago (2017-02-22 15:20:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699443005/20001
3 years, 10 months ago (2017-02-22 15:24:06 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 16:07:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/028db2b1bf62a5ce0574b3c1e7f4...

Powered by Google App Engine
This is Rietveld 408576698