Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2699443003: webapk: Don't swallow onbind exceptions (Closed)

Created:
3 years, 10 months ago by boliu
Modified:
3 years, 10 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webapk: Don't swallow onbind exceptions Browser side can't deal with returning null from onbind. Plus any exception there is already catastrophic, there is no way to recover from that anyway. BUG=691846 Review-Url: https://codereview.chromium.org/2699443003 Cr-Commit-Position: refs/heads/master@{#450580} Committed: https://chromium.googlesource.com/chromium/src/+/250eb5097bfcc2d24bf814ece2b48946b90cdec8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
boliu
ptal
3 years, 10 months ago (2017-02-14 23:11:56 UTC) #2
pkotwicz
LGTM
3 years, 10 months ago (2017-02-15 02:43:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699443003/1
3 years, 10 months ago (2017-02-15 02:49:49 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 06:07:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/250eb5097bfcc2d24bf814ece2b4...

Powered by Google App Engine
This is Rietveld 408576698