Chromium Code Reviews

Issue 2699403002: Simplify MediaStreamAudioSourceNode ownerships. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
haraken, Raymond Toy, hongchan
CC:
chromium-reviews, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify MediaStreamAudioSourceNode ownerships. The processing that happens on the audio thread for this object doesn't access the MediaStream. Hence the reference to it and the track can be kept directly on the node object, thereby avoiding the use of a pair of Persistent<>s. R=haraken BUG=693988 Review-Url: https://codereview.chromium.org/2699403002 Cr-Commit-Position: refs/heads/master@{#451726} Committed: https://chromium.googlesource.com/chromium/src/+/e27847a80deaea0674c951a7be26dda066a05cb8

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+18 lines, -28 lines)
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h View 4 chunks +10 lines, -15 lines 0 comments
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp View 6 chunks +8 lines, -13 lines 0 comments

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
sof
please take a look. while reviewing the use of Persistent<>s in Blink, I came across ...
3 years, 10 months ago (2017-02-20 07:24:35 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-20 09:34:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699403002/1
3 years, 10 months ago (2017-02-21 08:41:39 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 11:18:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e27847a80deaea0674c951a7be26...

Powered by Google App Engine