Place ellipsis correctly inside inline-blocks

Place ellipsis correctly inside inline-blocks

BUG=133700
Review-Url: https://codereview.chromium.org/2699393002
Cr-Commit-Position: refs/heads/master@{#453739}
Committed: https://chromium.googlesource.com/chromium/src/+/eab82c830edc973964782a440d878ed077e6a5be

[rhogan, 2017-02-19 18:58:36]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 18:58:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 20:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-19 20:36:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rhogan, 2017-02-21 21:26:07]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org, kojii@chromium.org

[rhogan, 2017-02-21 21:26:08]

I've more to do on the tests here (to tidy them up) and also add some text-align
tests but I think the code is ready for a look.

[eae, 2017-02-21 21:55:17]

This looks great! Have a few questions and suggestions though.

https://codereview.chromium.org/2699393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/2699393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:2459: for
(RootInlineBox* curr = firstRootBox; curr; curr = curr->nextRootBox()) {
It might be easier to move the ltr check outside of the loop?

if (ltr) {
  for (...)...
} else {
  for (...)...
}

Up to you!

https://codereview.chromium.org/2699393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:2500:
(availableLogicalWidth - totalLogicalWidth));
What happens if totalLogicalWidth is more than availableLogicalWidth or can that
never happen?

[rhogan, 2017-02-24 10:16:02]

On 2017/02/21 at 21:55:17, eae wrote:
> This looks great! Have a few questions and suggestions though.
> 
>
https://codereview.chromium.org/2699393002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp (right):
> 
>
https://codereview.chromium.org/2699393002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:2459: for
(RootInlineBox* curr = firstRootBox; curr; curr = curr->nextRootBox()) {
> It might be easier to move the ltr check outside of the loop?
> 
> if (ltr) {
>   for (...)...
> } else {
>   for (...)...
> }
> 
> Up to you!
> 
>
https://codereview.chromium.org/2699393002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:2500:
(availableLogicalWidth - totalLogicalWidth));
> What happens if totalLogicalWidth is more than availableLogicalWidth or can
that never happen?

I decided that we don't need to do any of this here. The RootInlineBox is the
last of a sequence attached to a series of atomic inlines on the line so
moving/resizing it will just misplace it in respect to the other atomic-inline
RootInlineBoxes on the line.

[rhogan, 2017-02-24 14:18:36]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 14:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2017-02-24 16:07:27]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 16:07:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 18:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 18:11:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[eae, 2017-02-25 01:17:26]

LGTM

[rhogan, 2017-02-28 21:05:43]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 21:06:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2017-02-28 21:08:41]

The CQ bit was unchecked by robhogan@gmail.com

[rhogan, 2017-02-28 21:08:46]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2017-02-28 21:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2699393002/#ps60001
(title: "bug 133700")

[commit-bot: I haz the power, 2017-02-28 21:09:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:26:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488316126431440,
"parent_rev": "31690fb03a1ca682147c4e1f81a7d8479c88a233", "commit_rev":
"eab82c830edc973964782a440d878ed077e6a5be"}

[commit-bot: I haz the power, 2017-02-28 23:26:51]

Description was changed from

==========
Place ellipsis correctly inside inline-blocks

BUG=133700
==========

to

==========
Place ellipsis correctly inside inline-blocks

BUG=133700

Review-Url: https://codereview.chromium.org/2699393002
Cr-Commit-Position: refs/heads/master@{#453739}
Committed:
https://chromium.googlesource.com/chromium/src/+/eab82c830edc973964782a440d87...
==========

[commit-bot: I haz the power, 2017-02-28 23:26:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/eab82c830edc973964782a440d87...