Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2699273002: Use job id from JobEventDetails to create CupsPrintJobs. (Closed)

Created:
3 years, 10 months ago by skau
Modified:
3 years, 10 months ago
Reviewers:
xdai, Carlson, xdai1
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use job id from JobEventDetails to create CupsPrintJobs. By using job id from JobEventDetails, we can avoid querying CUPS to display the initial notification and we don't have to guess if we've identified the correct job. This wasn't done originally, because job id was not present in JobEventDetails. Additionally, add some rate limiting for queries and check for jobs which we lose track of. Speculatively, this fixes 682853 as cupsd can become overwhelmed and stop responding to queries. BUG=684853, 682853 Review-Url: https://codereview.chromium.org/2699273002 Cr-Commit-Position: refs/heads/master@{#452281} Committed: https://chromium.googlesource.com/chromium/src/+/6157021217dd1922d6f5dcc8fd00b6e36bbb3a32

Patch Set 1 #

Patch Set 2 : add rate limiting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -32 lines) Patch
M chrome/browser/chromeos/printing/cups_print_job_manager_impl.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc View 1 4 chunks +38 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
skau
Please take a look!
3 years, 10 months ago (2017-02-18 02:24:22 UTC) #3
skau
I guess this got lost. Can you take a look? :)
3 years, 10 months ago (2017-02-22 21:44:12 UTC) #4
xdai1
On 2017/02/22 21:44:12, skau wrote: > I guess this got lost. Can you take a ...
3 years, 10 months ago (2017-02-22 22:34:18 UTC) #5
Carlson
lgtm Apologies for missing this.
3 years, 10 months ago (2017-02-22 23:08:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699273002/20001
3 years, 10 months ago (2017-02-22 23:15:10 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 23:52:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6157021217dd1922d6f5dcc8fd00...

Powered by Google App Engine
This is Rietveld 408576698