Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2699223003: [tab_grid] Hack-in new tab FAB action. (Closed)

Created:
3 years, 10 months ago by edchin
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tab_grid] Hack-in new tab FAB action. BUG=686770 Review-Url: https://codereview.chromium.org/2699223003 Cr-Commit-Position: refs/heads/master@{#451910} Committed: https://chromium.googlesource.com/chromium/src/+/4f7222a63ccfd557e7ef1657fee3b4b7ab1467c1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M ios/clean/chrome/browser/ui/actions/tab_grid_actions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/commands/tab_commands.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/mdc_floating_button+cr_tab_grid.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
edchin
3 years, 10 months ago (2017-02-20 01:09:28 UTC) #4
marq (ping after 24h)
LGTM % one comment nit. https://codereview.chromium.org/2699223003/diff/20001/ios/clean/chrome/browser/ui/commands/tab_commands.h File ios/clean/chrome/browser/ui/commands/tab_commands.h (right): https://codereview.chromium.org/2699223003/diff/20001/ios/clean/chrome/browser/ui/commands/tab_commands.h#newcode22 ios/clean/chrome/browser/ui/commands/tab_commands.h:22: // Create new tab ...
3 years, 10 months ago (2017-02-20 10:14:56 UTC) #5
jif
lgtm
3 years, 10 months ago (2017-02-20 16:50:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699223003/40001
3 years, 10 months ago (2017-02-21 22:53:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on ...
3 years, 10 months ago (2017-02-22 00:57:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699223003/40001
3 years, 10 months ago (2017-02-22 06:56:41 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 07:15:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4f7222a63ccfd557e7ef1657fee3...

Powered by Google App Engine
This is Rietveld 408576698