Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2699083002: html_diff: Show context lines at the beginning/end of a file correctly. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

html_diff: Show context lines at the beginning/end of a file correctly. If insertion happened at the beginning/end of a file, html_diff incorrectly skipped to show context lines. This CL fixes it. BUG=691883 Review-Url: https://codereview.chromium.org/2699083002 Cr-Commit-Position: refs/heads/master@{#451415} Committed: https://chromium.googlesource.com/chromium/src/+/d69da860fbe6e4b6a0ad3f4a7a79f816a2adfd75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/html_diff.py View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/html_diff_unittest.py View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
tkent
qyearsley@, would you review this please?
3 years, 10 months ago (2017-02-17 07:56:00 UTC) #7
qyearsley
lgtm
3 years, 10 months ago (2017-02-17 23:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699083002/1
3 years, 10 months ago (2017-02-17 23:54:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-18 01:58:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699083002/1
3 years, 10 months ago (2017-02-18 02:12:48 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 04:09:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d69da860fbe6e4b6a0ad3f4a7a79...

Powered by Google App Engine
This is Rietveld 408576698