Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2699073002: Make MockImageCaptureClient RefCountedThreadSafe (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MockImageCaptureClient RefCountedThreadSafe MockImageCaptureClient has non-thread-safe ref count, and touched from multiple threads. Though the access ordering to the ref count is well controlled and there's no data race, the usage causes a false positive DCHECK failure on an upcoming strict execution sequence check by: https://codereview.chromium.org/2666423002/ This CL converts MockImageCaptureClient to RefCountedThreadSafe to avoid the failure. BUG=688072 Review-Url: https://codereview.chromium.org/2699073002 Cr-Commit-Position: refs/heads/master@{#451562} Committed: https://chromium.googlesource.com/chromium/src/+/d8359a676ba9f7c6446f5aa2449466ff517efc9c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/capture/video/video_capture_device_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-17 12:15:39 UTC) #7
mcasas
lgtm
3 years, 10 months ago (2017-02-17 16:36:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699073002/20001
3 years, 10 months ago (2017-02-20 04:01:11 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 05:33:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d8359a676ba9f7c6446f5aa24494...

Powered by Google App Engine
This is Rietveld 408576698