Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2699053002: treat void as a top type, analyzer fix for #28763

Created:
3 years, 10 months ago by Jennifer Messerly
Modified:
3 years, 10 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org, Lasse Reichstein Nielsen, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

treat void as a top type, analyzer fix for #28763 void is treated as a top type in the type system. (along with Object, dynamic, and FutureOr< any top type >)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -80 lines) Patch
M pkg/analyzer/lib/src/generated/type_system.dart View 4 chunks +1 line, -30 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 2 chunks +14 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 10 chunks +10 lines, -10 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 10 chunks +10 lines, -10 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 10 chunks +10 lines, -10 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 10 chunks +10 lines, -10 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
3 years, 10 months ago (2017-02-17 03:38:53 UTC) #3
Leaf
On 2017/02/17 03:38:53, Jennifer Messerly wrote: I think we should hold off on this until ...
3 years, 10 months ago (2017-02-17 18:12:58 UTC) #4
Jennifer Messerly
On 2017/02/17 18:12:58, Leaf wrote: > On 2017/02/17 03:38:53, Jennifer Messerly wrote: > > I ...
3 years, 10 months ago (2017-02-17 18:20:51 UTC) #5
Leaf
3 years, 10 months ago (2017-02-17 20:30:30 UTC) #6
On 2017/02/17 18:20:51, Jennifer Messerly wrote:
> On 2017/02/17 18:12:58, Leaf wrote:
> > On 2017/02/17 03:38:53, Jennifer Messerly wrote:
> > 
> > I think we should hold off on this until we have a draft spec from Lasse
> (which
> > I would expect will be shared with the team shortly).  There's a couple of
> > things in here that I'm not sure match up exactly with the current proposal,
> and
> > I'd rather avoid hysteresis unless there's a good reason to do this now.
> 
> sounds good. Did we jump the gun implementing this in DDC?

No, I'm fine with the DDC runtime being ahead of the analyzer implementation.  I
think the current DDC semantics are compatible with Lasse's proposal.  Basically
at runtime void is Object (modulo pretty-printing), statically there are some
additional restrictions.  Similar treatment to dynamic in that way: Object +-
some static warnings.

Powered by Google App Engine
This is Rietveld 408576698