treat void as a top type, analyzer fix for #28763

pkg/dev_compiler/lib/js/legacy/dart_sdk.js

Index: pkg/dev_compiler/lib/js/legacy/dart_sdk.js
diff --git a/pkg/dev_compiler/lib/js/legacy/dart_sdk.js b/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
index 295dd7fad310c9d3933839e5e42256b798949d2f..491f818a28d406d3a0fb36038328dd107103e005 100644
--- a/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
+++ b/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
@@ -10440,7 +10440,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
 
               if (async.Future.is(newValue)) {
                 subscription.pause();
-                newValue.then(dart.void)(add, {onError: addError}).whenComplete(dart.bind(subscription, 'resume'));
+                newValue.then(dart.dynamic)(add, {onError: addError}).whenComplete(dart.bind(subscription, 'resume'));
               } else {
                 controller.add(E.as(newValue));
               }
@@ -18846,7 +18846,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
       onDone(handleDone) {}
       pause(resumeSignal) {
         if (resumeSignal === void 0) resumeSignal = null;
-        if (resumeSignal != null) resumeSignal.then(dart.void)(dart.bind(this, _resume));
+        if (resumeSignal != null) resumeSignal.then(dart.dynamic)(dart.bind(this, _resume));
         this[_pauseCount] = dart.notNull(this[_pauseCount]) + 1;
       }
       resume() {
@@ -39592,7 +39592,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
       dart.fn(onReady, RandomAccessFileTovoid());
       const onOpenFile = (function(file) {
         if (dart.notNull(this[_position$0]) > 0) {
-          file.setPosition(this[_position$0]).then(dart.void)(onReady, {onError: dart.fn((e, s) => {
+          file.setPosition(this[_position$0]).then(dart.dynamic)(onReady, {onError: dart.fn((e, s) => {
               this[_controller$0].addError(e, core.StackTrace._check(s));
               this[_readInProgress] = false;
               this[_closeFile]();
@@ -39609,7 +39609,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
       }).bind(this);
       dart.fn(openFailed, dynamicAnddynamicTovoid$());
       if (this[_path$] != null) {
-        io.File.new(this[_path$]).open({mode: io.FileMode.READ}).then(dart.void)(onOpenFile, {onError: openFailed});
+        io.File.new(this[_path$]).open({mode: io.FileMode.READ}).then(dart.dynamic)(onOpenFile, {onError: openFailed});
       } else {
         try {
           onOpenFile(io._File._openStdioSync(0));
@@ -43218,7 +43218,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
         return this.done;
       }
       [_closeTarget]() {
-        this[_target$].close().then(dart.void)(dart.bind(this, _completeDoneValue), {onError: dart.bind(this, _completeDoneError)});
+        this[_target$].close().then(dart.dynamic)(dart.bind(this, _completeDoneValue), {onError: dart.bind(this, _completeDoneError)});
       }
       get done() {
         return this[_doneCompleter].future;
@@ -43875,7 +43875,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
       } else {
         future = FutureOfHttpClientResponse().value(response);
       }
-      future.then(dart.void)(dart.fn(v => this[_responseCompleter].complete(v), HttpClientResponseTovoid()), {onError: dart.bind(this[_responseCompleter], 'completeError')});
+      future.then(dart.dynamic)(dart.fn(v => this[_responseCompleter].complete(v), HttpClientResponseTovoid()), {onError: dart.bind(this[_responseCompleter], 'completeError')});
     }
     [_onError$](error, stackTrace) {
       this[_responseCompleter].completeError(error, stackTrace);
@@ -44520,7 +44520,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
     close() {
       this.closed = true;
       this[_httpClient][_connectionClosed](this);
-      this[_streamFuture].then(dart.void)(dart.fn(_ => this[_socket].destroy(), dynamicTovoid$()));
+      this[_streamFuture].then(dart.dynamic)(dart.fn(_ => this[_socket].destroy(), dynamicTovoid$()));
     }
     createProxyTunnel(host, port, proxy, callback) {
       let request = this.send(core.Uri.new({host: core.String._check(host), port: core.int._check(port)}), core.int._check(port), "CONNECT", io._Proxy._check(proxy));
@@ -44679,7 +44679,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
       if (client.maxConnectionsPerHost != null && dart.notNull(this[_active].length) + dart.notNull(this[_connecting]) >= dart.notNull(client.maxConnectionsPerHost)) {
         let completer = async.Completer.new();
         this[_pending$].add(dart.fn(() => {
-          this.connect(uriHost, uriPort, proxy, client).then(dart.void)(dart.bind(completer, 'complete'), {onError: dart.bind(completer, 'completeError')});
+          this.connect(uriHost, uriPort, proxy, client).then(dart.dynamic)(dart.bind(completer, 'complete'), {onError: dart.bind(completer, 'completeError')});
         }, VoidToNull()));
         return FutureOf_ConnectionInfo()._check(completer.future);
       }
@@ -49221,7 +49221,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
       this[_closedWrite] = true;
       this[_closedRead] = true;
       if (this[_socket] != null) {
-        this[_socket].close().then(dart.void)(dart.bind(this, _completeCloseCompleter));
+        this[_socket].close().then(dart.dynamic)(dart.bind(this, _completeCloseCompleter));
       } else {
         this[_completeCloseCompleter]();
       }
@@ -51582,7 +51582,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
     }
     bind(stream) {
       stream.listen(dart.fn(request => {
-        io._WebSocketTransformerImpl._upgrade(request, this[_protocolSelector], this[_compression]).then(dart.void)(dart.fn(webSocket => this[_controller$0].add(webSocket), WebSocketTovoid())).catchError(dart.bind(this[_controller$0], 'addError'));
+        io._WebSocketTransformerImpl._upgrade(request, this[_protocolSelector], this[_compression]).then(dart.dynamic)(dart.fn(webSocket => this[_controller$0].add(webSocket), WebSocketTovoid())).catchError(dart.bind(this[_controller$0], 'addError'));
       }, HttpRequestToNull()), {onDone: dart.fn(() => {
           this[_controller$0].close();
         }, VoidToNull())});