Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2699033004: MD Settings: Fix Privacy section Learn More link. (Closed)

Created:
3 years, 10 months ago by tommycli
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix Privacy section Learn More link. BUG=619788 Review-Url: https://codereview.chromium.org/2699033004 Cr-Commit-Position: refs/heads/master@{#451798} Committed: https://chromium.googlesource.com/chromium/src/+/50549d69c7c12eb9058011dac35c6b7f351f51a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/settings_chromium_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/settings_google_chrome_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
tommycli
dbeam: PTAL before and after: http://imgur.com/a/CTS4b
3 years, 10 months ago (2017-02-17 23:18:06 UTC) #2
Dan Beam
lgtm
3 years, 10 months ago (2017-02-17 23:19:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699033004/1
3 years, 10 months ago (2017-02-17 23:22:59 UTC) #5
tommycli
On 2017/02/17 23:22:59, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago (2017-02-17 23:38:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-18 01:25:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699033004/1
3 years, 10 months ago (2017-02-21 17:17:47 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 18:15:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50549d69c7c12eb9058011dac35c...

Powered by Google App Engine
This is Rietveld 408576698