Clear cached QUIC network stats when a QUIC handshake fails.

net/http/http_server_properties_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_server_properties_impl.h"
 
 #include <memory>
 #include <string>
 #include <vector>
 
@@ skipping 1092 matching lines @@
   EXPECT_EQ(10, stats2->srtt.ToInternalValue());
   EXPECT_EQ(100, stats2->bandwidth_estimate.ToBitsPerSecond());
   // Https server should have nothing set for server network stats.
   EXPECT_EQ(NULL, impl_.GetServerNetworkStats(foo_https_server));
 
   impl_.Clear();
   EXPECT_EQ(NULL, impl_.GetServerNetworkStats(foo_http_server));
   EXPECT_EQ(NULL, impl_.GetServerNetworkStats(foo_https_server));
 }
 
+TEST_F(ServerNetworkStatsServerPropertiesTest, ClearServerNetworkStats) {
+  ServerNetworkStats stats;
+  stats.srtt = base::TimeDelta::FromMicroseconds(10);
+  stats.bandwidth_estimate = QuicBandwidth::FromBitsPerSecond(100);
+  url::SchemeHostPort foo_https_server("https", "foo", 443);
+  impl_.SetServerNetworkStats(foo_https_server, stats);
+
+  impl_.ClearServerNetworkStats(foo_https_server);

[Jana, 2017/02/17 02:52:12]

Nit: can you do a GetServerNetworkStats() before the clear, and confirm that
it's non-null?

[Ryan Hamilton, 2017/02/17 03:41:53]

I can but that's tested in the previous test, and the TotT guides say not to
have redundant expectations in tests. (In other words, from the previous test we
proved that SetStats() works. We don't need to re-prove it here)

+  EXPECT_EQ(nullptr, impl_.GetServerNetworkStats(foo_https_server));
+}
+
 typedef HttpServerPropertiesImplTest QuicServerInfoServerPropertiesTest;
 
 TEST_F(QuicServerInfoServerPropertiesTest, Set) {
   HostPortPair google_server("www.google.com", 443);
   QuicServerId google_quic_server_id(google_server, PRIVACY_MODE_ENABLED);
 
   EXPECT_EQ(QuicServerInfoMap::NO_AUTO_EVICT,
             impl_.quic_server_info_map().max_size());
   impl_.SetMaxServerConfigsStoredInProperties(10);
   EXPECT_EQ(10u, impl_.quic_server_info_map().max_size());
@@ skipping 88 matching lines @@
   EXPECT_EQ(quic_server_info1, *(impl_.GetQuicServerInfo(quic_server_id)));
 
   impl_.Clear();
   EXPECT_EQ(0u, impl_.quic_server_info_map().size());
   EXPECT_EQ(nullptr, impl_.GetQuicServerInfo(quic_server_id));
 }
 
 }  // namespace
 
 }  // namespace net