Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2698983004: DevTools: fix npm_test architecture check (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix npm_test architecture check process.arch is based on the architecture which node.js was compiled for, not necessarily the architecture of the system the node.js process is currently running in. I came across this issue while working on buildbot related stuff. More info: https://github.com/nodejs/node-v0.x-archive/issues/2862 BUG=none Review-Url: https://codereview.chromium.org/2698983004 Cr-Commit-Position: refs/heads/master@{#451511} Committed: https://chromium.googlesource.com/chromium/src/+/250263fa2e293a555c78479e00b5758c2e56d97e

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/scripts/npm_test.js View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
chenwilliam
ptal
3 years, 10 months ago (2017-02-18 00:39:54 UTC) #4
dgozman
lgtm
3 years, 10 months ago (2017-02-18 20:32:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698983004/60001
3 years, 10 months ago (2017-02-19 02:30:53 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-19 04:12:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/250263fa2e293a555c78479e00b5...

Powered by Google App Engine
This is Rietveld 408576698