Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2698953002: Disallow ScriptWrappables inside of static singletons.

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, dcheng, Navid Zolghadr, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow ScriptWrappables inside of static singletons. R= BUG= Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R= BUG= patch from issue 2687193004 at patchset 60001 (http://crrev.com/2687193004#ps60001)

Patch Set 1 #

Patch Set 2 : re-intro before-thread creation check #

Patch Set 3 : fix logic #

Patch Set 4 : attempt to drop before-thread check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -131 lines) Patch
M third_party/WebKit/Source/wtf/StdLibExtras.h View 1 2 3 1 chunk +96 lines, -70 lines 0 comments Download
M third_party/WebKit/Source/wtf/Threading.h View 2 chunks +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingPthreads.cpp View 2 chunks +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingWin.cpp View 3 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 16 (16 generated)
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-16 14:33:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698953002/1
3 years, 10 months ago (2017-02-16 14:34:37 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-16 15:35:10 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/233858)
3 years, 10 months ago (2017-02-16 15:35:11 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-16 15:39:14 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698953002/20001
3 years, 10 months ago (2017-02-16 15:39:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-16 16:40:28 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/120540) cast_shell_linux on ...
3 years, 10 months ago (2017-02-16 16:40:30 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-16 18:19:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698953002/40001
3 years, 10 months ago (2017-02-16 18:20:06 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-16 20:12:39 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 10 months ago (2017-02-16 20:12:40 UTC) #12
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 10 months ago (2017-02-16 21:51:35 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698953002/60001
3 years, 10 months ago (2017-02-16 21:52:59 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-16 23:19:29 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 23:19:30 UTC) #16 
Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698