Issue 269893004: Revert 268203 "There are many ways to get it wrong."

Issue 269893004: Revert 268203 "There are many ways to get it wrong." (Closed)

Created:
6 years, 7 months ago by benjhayden

Modified:
6 years, 7 months ago

Reviewers:
Thiemo Nagel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 268203 "There are many ways to get it wrong." > There are many ways to get it wrong. > > BUG=none > > TBR=darin (for base/) > TBR=sky (for chrome/ and ui/) > TBR=dconnelly (for components/policy/) > TBR=tommi (for media/audio/) > TBR=asvitkine (for tools/metrics/) > TBR=mad (for win8) > > Review URL: https://codereview.chromium.org/261293002 TBR=tnagel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268217

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -26 lines)			Patch
M	trunk/src/ash/system/tray/system_tray_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/system/web_notification/web_notification_tray_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/base/observer_list_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/notifications/sync_notifier/synced_notification_app_info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/sync/test/integration/sync_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/fast_unload_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/panels/test_panel_notification_observer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/unload_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/renderer/autofill/page_click_tracker_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/renderer/content_settings_observer_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/components/policy/core/common/schema_registry_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/audio/cras/cras_input.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/audio/cras/cras_unified.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/tools/metrics/histograms/histograms.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/file_manager/file_manager/background/js/device_handler.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/ui/message_center/cocoa/tray_view_controller.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/ui/message_center/message_center.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/message_center/views/message_center_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/win8/metro_driver/chrome_app_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

benjhayden

Committed patchset #1 manually as r268217 (tree was closed).

6 years, 7 months ago (2014-05-05 18:03:01 UTC) #2

chromium-reviews

6 years, 7 months ago (2014-05-06 17:06:38 UTC) #3

I looked long and hard at that CL, including running the telemetry test
locally, and I'm convinced that what you have observed was a flake. I'll
re-commit.

On Mon, May 5, 2014 at 8:03 PM, <benjhayden@chromium.org> wrote:

> Committed patchset #1 manually as r268217 (tree was closed).
>
> https://codereview.chromium.org/269893004/
>

-- 

Thiemo Nagel | Software Engineer | tnagel@google.com |

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages