Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 261293002: Improve spelling of "notification". (Closed)

Created:
6 years, 7 months ago by Thiemo Nagel
Modified:
6 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, sadrul, yoshiki+watch_chromium.org, dcheng, rginda+watch_chromium.org, mtomasz+watch_chromium.org, Ilya Sherman, tim+watch_chromium.org, jar (doing other things), benquan, kalyank, erikwright+watch_chromium.org, jennb, haitaol+watch_chromium.org, jianli, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, Dmitry Titov, Dane Wallinga, dyu1, estade+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Improve spelling of "notification". There are many ways to get it wrong. BUG=none TBR=darin (for base/) TBR=sky (for chrome/ and ui/) TBR=dconnelly (for components/policy/) TBR=tommi (for media/audio/) TBR=asvitkine (for tools/metrics/) TBR=mad (for win8) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268203 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269103

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M ash/system/tray/system_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/observer_list_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/sync_notifier/synced_notification_app_info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/fast_unload_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/test_panel_notification_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/unload_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/page_click_tracker_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/content_settings_observer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/schema_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/cras/cras_input.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/cras/cras_unified.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/tray_view_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/message_center.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_view.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/chrome_app_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Thiemo Nagel
Hi Steven, could you please take a look? There's really not a lot to say ...
6 years, 7 months ago (2014-05-05 16:28:18 UTC) #1
stevenjb
lgtm
6 years, 7 months ago (2014-05-05 16:37:52 UTC) #2
Thiemo Nagel
On 2014/05/05 16:37:52, stevenjb wrote: > lgtm Thank you!
6 years, 7 months ago (2014-05-05 16:38:42 UTC) #3
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 7 months ago (2014-05-05 16:38:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/261293002/1
6 years, 7 months ago (2014-05-05 16:39:22 UTC) #5
commit-bot: I haz the power
Change committed as 268203
6 years, 7 months ago (2014-05-05 16:54:06 UTC) #6
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 7 months ago (2014-05-08 12:52:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/261293002/40001
6 years, 7 months ago (2014-05-08 12:56:56 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 23:49:47 UTC) #9
Message was sent while issue was closed.
Change committed as 269103

Powered by Google App Engine
This is Rietveld 408576698