Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 269893003: Fix leak in RemotePtr::operator=(). (Closed)

Created:
6 years, 7 months ago by yzshen1
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Fix leak in RemotePtr::operator=(). BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M mojo/public/cpp/bindings/remote_ptr.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks! I know this file will go ...
6 years, 7 months ago (2014-05-04 18:14:45 UTC) #1
darin (slow to review)
Good catch, thanks!! LGTM
6 years, 7 months ago (2014-05-04 19:21:20 UTC) #2
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 7 months ago (2014-05-04 19:30:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/269893003/1
6 years, 7 months ago (2014-05-04 19:30:28 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 00:51:15 UTC) #5
Message was sent while issue was closed.
Change committed as 268134

Powered by Google App Engine
This is Rietveld 408576698