mojo/public/cpp/bindings/remote_ptr.h - Issue 269893003: Fix leak in RemotePtr::operator=().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/remote_ptr.h

Issue 269893003: Fix leak in RemotePtr::operator=(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/remote_ptr.h

diff --git a/mojo/public/cpp/bindings/remote_ptr.h b/mojo/public/cpp/bindings/remote_ptr.h

index 63ee719329544c2d314836fb2744770b522bca6c..9f7922615458316e89bc0cdd03fd9b16ffa12277 100644

--- a/mojo/public/cpp/bindings/remote_ptr.h

+++ b/mojo/public/cpp/bindings/remote_ptr.h

@@ -86,6 +86,7 @@ class RemotePtr {

// Move-only constructor and operator=.

RemotePtr(RValue other) : state_(other.object->release()) {}

RemotePtr& operator=(RValue other) {

+ delete state_;

state_ = other.object->release();

return *this;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »