Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2698913006: NQE: Record the main frame metrics at transaction start (Closed)

Created:
3 years, 10 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NQE: Record the main frame metrics at transaction start In network quality estimator (NQE), record the main frame metrics at the beginning of transaction start, instead of when the response headers have been received for the main frame. BUG=691798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2698913006 Cr-Commit-Position: refs/heads/master@{#451400} Committed: https://chromium.googlesource.com/chromium/src/+/c3d164f6e807c5f9669ceb4ba213475d6072d626

Patch Set 1 : Patch from https://codereview.chromium.org/2695783003/ #

Patch Set 2 : Potential fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -46 lines) Patch
M net/nqe/network_quality_estimator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 1 4 chunks +19 lines, -19 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 10 chunks +29 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tbansal1
ryansturm: ptal. thanks.
3 years, 10 months ago (2017-02-17 18:37:55 UTC) #2
RyanSturm
lgtm
3 years, 10 months ago (2017-02-17 19:26:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698913006/20001
3 years, 10 months ago (2017-02-17 21:30:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 23:43:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c3d164f6e807c5f9669ceb4ba213...

Powered by Google App Engine
This is Rietveld 408576698