Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2698883004: DevTools: expose session to handlers. (Closed)

Created:
3 years, 10 months ago by pfeldman
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: expose session to handlers. BUG=659662 Review-Url: https://codereview.chromium.org/2698883004 Cr-Commit-Position: refs/heads/master@{#451180} Committed: https://chromium.googlesource.com/chromium/src/+/2db168c3d25fe70212765f4b7404711031a8b827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M content/browser/devtools/devtools_agent_host_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/devtools_domain_handler.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/devtools_domain_handler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/security_handler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/security_handler.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pfeldman
3 years, 10 months ago (2017-02-16 22:16:42 UTC) #2
dgozman
lgtm
3 years, 10 months ago (2017-02-16 22:30:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698883004/1
3 years, 10 months ago (2017-02-16 22:32:28 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 02:15:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2db168c3d25fe70212765f4b7404...

Powered by Google App Engine
This is Rietveld 408576698